Skip to content

[CI] Await the example button before tapping it in Argent flows - #4482

Open
j-piasecki wants to merge 1 commit into
push-uplzounpwmlpfrom
push-rnqlolrvlkrs
Open

[CI] Await the example button before tapping it in Argent flows#4482
j-piasecki wants to merge 1 commit into
push-uplzounpwmlpfrom
push-rnqlolrvlkrs

Conversation

@j-piasecki

Copy link
Copy Markdown
Member

Description

The search results may not be rendered yet when the flow taps the example button right after typing into the search field. Await the button in every flow before tapping it.

Test plan

Run the flows in .argent/flows and check that they pass.

## Description

The search results may not be rendered yet when the flow taps the example button right after typing into the search field. Await the button in every flow before tapping it.

## Test plan

Run the flows in `.argent/flows` and check that they pass.
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: c4a48e19-bf41-4250-aa04-0a0b6daff8de

📥 Commits

Reviewing files that changed from the base of the PR and between 3ede23e and 6743923.

📒 Files selected for processing (5)
  • .argent/flows/basic-long-press-test.yaml
  • .argent/flows/basic-tap-test.yaml
  • .argent/flows/nested-touchables-test.yaml
  • .argent/flows/shared-value-test.yaml
  • .argent/flows/timer-test.yaml

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.


📝 Summary

Summary by CodeRabbit

  • Tests
    • Improved example navigation test reliability by waiting for search results to appear before opening:
      • Basic LongPress
      • Basic Tap
      • Nested Touchables
      • Shared Value
      • Timer

Walkthrough

Five Argent test flows now wait for their searched example to become visible before tapping it.

Changes

Example search flow synchronization

Layer / File(s) Summary
Wait for searched examples before tapping
.argent/flows/basic-long-press-test.yaml, .argent/flows/basic-tap-test.yaml, .argent/flows/nested-touchables-test.yaml, .argent/flows/shared-value-test.yaml, .argent/flows/timer-test.yaml
Each flow waits for the matching example text after entering the search query and before tapping the result.

Merge Risk: ⚪ Minimal · up to 67439

The updated CI flows wait for searched examples to render before opening them, reducing timing-related test failures. No current merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: adding waits before tapping example buttons in Argent flows.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant