Skip to content

fix(fabric): prevent Yoga layout assertion crash in RNGestureHandlerDetectorShadowNode #4500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AKASH80047 wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −3
Open

fix(fabric): prevent Yoga layout assertion crash in RNGestureHandlerDetectorShadowNode #4500

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...react/renderer/components/rngesturehandler_codegen/RNGestureHandlerDetectorShadowNode.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,9 +72,8 @@ void RNGestureHandlerDetectorShadowNode::layout(LayoutContext layoutContext) {
// Default layout will reset the flag on child nodes.
YogaLayoutableShadowNode::layout(layoutContext);

// No child had its layout changed, we can reuse previous values
if (!anyChildHasNewLayout) {
react_native_assert(previousLayoutMetrics_.has_value());
// No child had its layout changed, we can reuse previous values if available
if (!anyChildHasNewLayout && previousLayoutMetrics_.has_value()) {
setLayoutMetrics(previousLayoutMetrics_.value());
return;
Comment on lines +75 to 78
}
Expand All @@ -101,6 +100,7 @@ void RNGestureHandlerDetectorShadowNode::layout(LayoutContext layoutContext) {
metrics.frame.origin = Point{minX, minY};
metrics.frame.size = Size{maxX - minX, maxY - minY};
setLayoutMetrics(metrics);
previousLayoutMetrics_ = metrics;

// Shift all children so their positions are relative to the detector's origin
for (const auto &child : children) {
Expand Down