Add sbt-salad-days plugin to all sbt-softwaremill projects#376
Merged
Conversation
Adds com.eed3si9n:sbt-salad-days:0.2.0 to the common module so that all projects using sbt-softwaremill pick it up transitively. The plugin reduces Scaladoc JAR file size by stripping bundled fonts. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add the plugin to the meta-build (project/build.sbt) so sbt-softwaremill slims its own Scaladoc JARs too, not just downstream consumers'. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Define sbtSaladDaysVersion once in project/build.sbt and export it through BuildInfo, so the meta-build and the common module share a single source of truth (matching how sbt-scalafmt's version is handled). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds sbt-salad-days v0.2.0 to the
commonmodule.What
build.sbt:addSbtPlugin("com.eed3si9n" % "sbt-salad-days" % "0.2.0")in thecommonproject.README.md: list it under whatsbt-softwaremill-commoncomes with.Why
commonsbt-softwaremill is a meta-plugin: each module's
addSbtPlugin(...)is exposed transitively to downstream consumers. Every project using sbt-softwaremill depends onsbt-softwaremill-common(the universal baseline alongside sbt-scalafmt and sbt-tpolecat), whereaspublish/extra/browser-test-jsare opt-in. Placing it incommonensures all projects pick it up, as requested.sbt-salad-days reduces Scaladoc JAR file size by stripping bundled fonts.
Verification
sbt common/updateresolves the new plugin dependency successfully (coordinates confirmed on Maven Central for sbt 1.0 / Scala 2.12).🤖 Generated with Claude Code