Merged
Conversation
albertsola
requested review from
d3rky,
jentyk,
ruben-sebrango and
svazquezco
as code owners
albertsola
force-pushed
the
asola/MPT-12325/Implement-base-CollectionClient
branch
2 times, most recently
from
95d38d8 to
7c9c5d8
Compare
albertsola
changed the title
albertsola
force-pushed
the
asola/MPT-12325/Implement-base-CollectionClient
branch
2 times, most recently
from
6c7c04c to
934f488
Compare
svazquezco
approved these changes
Aug 14, 2025
Comment on lines
75
to
88
| """Returns new collection with ordering setup. | ||
|
|
||
| Raises ValueError if ordering is already set. | ||
| """ |
Contributor
There was a problem hiding this comment.
Returns and raises should be part of a section in the doctrings.
mpt_api_client/http/collection.py
Outdated
| return new_collection | ||
|
|
||
| def select(self, *fields: str) -> Self: | ||
| """Set select fields. Raises ValueError if select fields are already set.""" |
Contributor
There was a problem hiding this comment.
Same about the doctsrings format. Raises should be part of the Raises section
albertsola
force-pushed
the
asola/MPT-12325/Implement-base-CollectionClient
branch
3 times, most recently
from
1d7218b to
fa0b2f7
Compare
albertsola
force-pushed
the
asola/MPT-12325/Implement-base-CollectionClient
branch
from
fa0b2f7 to
b5279fd
Compare
|
robcsegal
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.