Merged
Conversation
albertsola
force-pushed
the
MPT-12330/order_resource_client
branch
from
be9bc0d to
81d44d5
Compare
albertsola
force-pushed
the
MPT-12330/order_resource_client
branch
2 times, most recently
from
eb11da4 to
aeae1f1
Compare
albertsola
requested review from
alephsur,
d3rky,
jentyk,
robcsegal,
ruben-sebrango and
svazquezco
as code owners
robcsegal
approved these changes
Aug 20, 2025
albertsola
force-pushed
the
MPT-12330/order_resource_client
branch
from
aeae1f1 to
86765f8
Compare
albertsola
force-pushed
the
MPT-12330/order_resource_client
branch
from
86765f8 to
c5027f5
Compare
|
ruben-sebrango
approved these changes
Aug 21, 2025
jentyk
reviewed
Aug 21, 2025
|
|
||
|
|
||
| class MPTClient(httpx.Client): | ||
| class HTTPClient(httpx.Client): |
Contributor
There was a problem hiding this comment.
Why is this name better? Before it was a bit more specific
Contributor
Author
There was a problem hiding this comment.
mpt_api_client/http/client.py: HTTPClient is the class that manages the http connection (Auth and headers).
Now with this PR we have a new MPTClient to be used in mpt_api_client/mptclient.py which gives you access to a higher level of abstraction layer to access the MPT API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.