Skip to content

Comments

[MPT-18215] Fix failing unauthorised e2e test#215

Merged
robcsegal merged 1 commit intomainfrom
MPT-18215-fix-failing-unauthorised-e-2-e-test
Feb 18, 2026
Merged

[MPT-18215] Fix failing unauthorised e2e test#215
robcsegal merged 1 commit intomainfrom
MPT-18215-fix-failing-unauthorised-e-2-e-test

Conversation

@robcsegal
Copy link
Contributor

@robcsegal robcsegal commented Feb 18, 2026

Fix failing unauthorised e2e test

https://softwareone.atlassian.net/browse/MPT-18215

Closes MPT-18215

  • Fixed failing unauthorised e2e test by updating import from MPTAPIError to MPTHttpError
  • Updated test assertion in test_unauthorised to expect MPTHttpError matching "401 Unauthorized"

@robcsegal robcsegal requested a review from a team as a code owner February 18, 2026 16:31
@coderabbitai
Copy link

coderabbitai bot commented Feb 18, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Walkthrough

Replaced MPTAPIError with MPTHttpError in tests/e2e/test_access.py: updated the import and the pytest.raises assertion in the test_unauthorised test to expect MPTHttpError with a "401 Unauthorized" match.

Changes

Cohort / File(s) Summary
Exception handling update
tests/e2e/test_access.py
Changed import from MPTAPIError to MPTHttpError; updated with pytest.raises(...) in test_unauthorised to expect MPTHttpError and match 401 Unauthorized.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Jira Issue Key In Title ✅ Passed The PR title contains exactly one Jira issue key in the correct format MPT-18215, properly formatted as MPT-18215 at the beginning.
Test Coverage Required ✅ Passed PR only modifies test files and no code files outside tests/ folder, meeting the passing condition.
Single Commit Required ✅ Passed The pull request contains exactly one commit (ad5d64f Fix failing unauthorised e2e test), meeting the requirement for clean git history.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@robcsegal robcsegal force-pushed the MPT-18215-fix-failing-unauthorised-e-2-e-test branch from 0aaacd9 to ad5d64f Compare February 18, 2026 16:42
@sonarqubecloud
Copy link

@robcsegal robcsegal merged commit 5f1a75c into main Feb 18, 2026
4 checks passed
@robcsegal robcsegal deleted the MPT-18215-fix-failing-unauthorised-e-2-e-test branch February 18, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants