Add sub-pool sync waits and test fixes#367
Merged
SteveChurchillSWO merged 1 commit intomainfrom Feb 27, 2026
Merged
Conversation
Add a subPoolAddIcon locator to PoolsPage and use it as an additional synchronization point after saving/editing pools (waitFor on the icon) to ensure the page has fully loaded. Add extra waitForAllProgressBarsToDisappear calls in several tests where needed. Update pools tests to fetch forecastThisMonth and branch assertions depending on whether forecast exceeds the organization limit (adjust colors and expected icons accordingly). Rename one test title for clarity and fix a comparison to use a 0.9 multiplier instead of division. Increase test timeouts from 90s to 120s in resources tests. Minor test stability and assertion improvements related to sub-pool limit editing and UI state.
antoniodimariano
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a subPoolAddIcon locator to PoolsPage and use it as an additional synchronization point after saving/editing pools (waitFor on the icon) to ensure the page has fully loaded. Add extra waitForAllProgressBarsToDisappear calls in several tests where needed. Update pools tests to fetch forecastThisMonth and branch assertions depending on whether forecast exceeds the organization limit (adjust colors and expected icons accordingly). Rename one test title for clarity and fix a comparison to use a 0.9 multiplier instead of division. Increase test timeouts from 90s to 120s in resources tests. Minor test stability and assertion improvements related to sub-pool limit editing and UI state.
Related issue number
https://softwareone.atlassian.net/browse/MPT-18492