-
Notifications
You must be signed in to change notification settings - Fork 0
Having OAuth #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Having OAuth #11
Conversation
SKernchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The OAUTH is working pretty well.
However can you integrate the token you get, so that you can use it?
When you put it in the Token field it is not supported because it has the wrong form. And you are also not redirected to be authentificated. So that would be very helpful.
|
It seems the OAuth tokens have to be treated differently. They do not start with "glpat-" and we have to use |
SKernchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Auth works nice, however fetching the pipeline does not work (I think because of the header).
So please include this (dashboard/main.js is one file for that).
Another thing that we discussed in the previous meeting was, if we include both headers or use an if-statement to distingluish (via name pattern) between them.
In my opinion the second way would be cleaner but I don't care
public/gitlab-setup/index.html
Outdated
| Alternatively you can use OAuth: | ||
| </p> | ||
| <button id="oauth-helmholtz-button">Connect to Helmholtz</button> | ||
| <button id="oauth-jugit-button" disabled>Connect to Jugit</button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why disabled?
…ces. Added module for user and git platform info
Closes #3