feat(android): VIN-driven Tesla enrollment UX (3/3) - #208
Closed
dkneeland wants to merge 1 commit into
Closed
Conversation
dkneeland
force-pushed
the
feat/tesla-vin-enrollment
branch
from
August 25, 2026 23:32
240a7c1 to
665f5c6
Compare
Replace manual VIN entry and nearby-car discovery with a VIN-driven enrollment flow: - TeslaEnrollmentController state machine: firmware check, wait for VIN, VIN-matched scan, automatic provisioning, explicit Connect consent, key-card pairing states, bounded timeouts with actionable errors (unsupported firmware, VIN unavailable, vehicle not found) - TeslaEnrollFlow renders controller state; no soft keyboard, no staging confirmation beat - Home/Settings Tesla tile entry points; reset-pending plumbing; masked VIN display only (Tesla - VIN ****1234) - kotlinx-coroutines-test for controller tests Requires DashKit firmware with Tesla app-channel + VIN forwarding.
dkneeland
force-pushed
the
feat/tesla-vin-enrollment
branch
from
August 25, 2026 23:46
665f5c6 to
315e018
Compare
Collaborator
Author
|
Re-created as top layer of the re-layered stack: see the successor PR (opened alongside this closure). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3 of 3 of a stacked series that supersedes #201 (closed; work redistributed across this stack). Stacks on Parts 1–2.
What & why
VIN-driven Tesla enrollment UX replacing manual VIN entry and nearby-car discovery:
TeslaEnrollmentControllerstate machine owns discovery, provisioning, timeouts, retries, and VIN-dependent transitions:CheckingFirmware → WaitingForVin → FindingVehicle(maskedVin) → Provisioning → ReadyToConnect → Connecting → WaitingForKeyCard → Success / Error(retryable)Composables render state and dispatch actions only.
CMD_PROVISIONwith DashKit VIN + matched address; waits forStaged. The explicit Connect action remains before key enrollment (Charging Manager role + key-card requirement explained in-UI).Tesla · VIN ••••1234).kotlinx-coroutines-testadded for controller tests.Tests
Controller state-machine tests (firmware unsupported, missing VIN never provisions, dispatch-is-not-ack, staged-before-connect, timeouts) and tile tests. Full
testDebugUnitTestgreen at carve time. Final tree verified identical to the pre-split working state.Follow-ups
On-device validation matrix from the plan doc remains (real DashKit + Tesla: asleep→awake, legacy/modern advertisements, reconnect storms, logcat/persistence audit). Firmware version gating currently feature-detects service presence; version-bump-based gating lands with the firmware release (dashkit-firmware#59).
Stack & merge order
Merge after Parts 1 and 2. Click Update branch after Part 2 merges (base retargets to
main) so the diff collapses to just this PR's changes, then squash-merge.