Refactor: remove duplicate initialize(mFrequencies) calls and migrate SVC to CompositePowerComp (#508)#511
Merged
leonardocarreras merged 2 commits intoJun 29, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #511 +/- ##
==========================================
- Coverage 67.38% 67.34% -0.05%
==========================================
Files 426 426
Lines 26037 25991 -46
Branches 13246 13217 -29
==========================================
- Hits 17546 17504 -42
+ Misses 8490 8440 -50
- Partials 1 47 +46 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
georgii-tishenin
approved these changes
Jun 29, 2026
georgii-tishenin
left a comment
Contributor
There was a problem hiding this comment.
Hi @leonardocarreras. The refactoring looks good to me.
…SubComponents Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
b950478 to
e7234bc
Compare
4d49d5b
into
sogno-platform:master
30 of 31 checks passed
This was referenced Jun 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
->initialize(mFrequencies)calls fromcreateSubComponents()andinitializeParentFromNodesAndTerminals()in 13 composite component files;CompositePowerComp::initializeFromNodesAndTerminals()already calls this for every registered sub-component, making the earlier calls redundantDP_Ph1_SVCfrom the oldMNASimPowerComppattern toCompositePowerComp, matching the pattern introduced by fix: virtual node ordering for composite components (#270) #496; adds the missinghasParameterChanged()override required byMNAVariableCompInterfaceand fixes pre-existing signature mismatchesCloses #508.