Skip to content

Refactor: remove duplicate initialize(mFrequencies) calls and migrate SVC to CompositePowerComp (#508)#511

Merged
leonardocarreras merged 2 commits into
sogno-platform:masterfrom
leonardocarreras:refactor/issue-508
Jun 29, 2026
Merged

Refactor: remove duplicate initialize(mFrequencies) calls and migrate SVC to CompositePowerComp (#508)#511
leonardocarreras merged 2 commits into
sogno-platform:masterfrom
leonardocarreras:refactor/issue-508

Conversation

@leonardocarreras

Copy link
Copy Markdown
Contributor

Summary

  • Remove duplicate ->initialize(mFrequencies) calls from createSubComponents() and initializeParentFromNodesAndTerminals() in 13 composite component files; CompositePowerComp::initializeFromNodesAndTerminals() already calls this for every registered sub-component, making the earlier calls redundant
  • Migrate DP_Ph1_SVC from the old MNASimPowerComp pattern to CompositePowerComp, matching the pattern introduced by fix: virtual node ordering for composite components (#270) #496; adds the missing hasParameterChanged() override required by MNAVariableCompInterface and fixes pre-existing signature mismatches

Closes #508.

@codecov

codecov Bot commented Jun 19, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.34%. Comparing base (51ab0e4) to head (e7234bc).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #511      +/-   ##
==========================================
- Coverage   67.38%   67.34%   -0.05%     
==========================================
  Files         426      426              
  Lines       26037    25991      -46     
  Branches    13246    13217      -29     
==========================================
- Hits        17546    17504      -42     
+ Misses       8490     8440      -50     
- Partials        1       47      +46     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@leonardocarreras leonardocarreras self-assigned this Jun 22, 2026
@leonardocarreras leonardocarreras added enhancement New feature or request refactor Issues related to code refactoring labels Jun 22, 2026

@georgii-tishenin georgii-tishenin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @leonardocarreras. The refactoring looks good to me.

…SubComponents

Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
Signed-off-by: Leonardo Carreras <leonardo.carreras@eonerc.rwth-aachen.de>
@leonardocarreras leonardocarreras merged commit 4d49d5b into sogno-platform:master Jun 29, 2026
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request refactor Issues related to code refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup of subcomponents to match the new pattern introduced on #496

2 participants