chore: final polish before v1.6.0 stable#42
Merged
Merged
Conversation
Three small items surfaced in the last-look review. No runtime
behaviour change for existing tools.
1. Harden DESTRUCTIVE_TOOLS against future drift. Was a hardcoded
Set of 7 names — a future delete_X tool added without remembering
to update the Set would ship as a routine write (no client
confirmation prompt). Switched to delete_ prefix + 2 explicit
non-delete exceptions (remove_track, remove_additional_party).
New delete_X tools auto-inherit destructiveHint. Test added to
pin the safety net.
2. Enrich glama.json. Was just { maintainers: ["arapov"] } — now
includes description + categories so the registry card has
actual content for glama.ai's listing scrape.
3. README at-a-glance bullet about MCP tool annotations. The
auto-approval improvement landed in rc.3 but didn't make the
at-a-glance section — adds a one-line callout.
469 tests (was 468). No bundle size change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Last-look review surfaced three small items worth landing before v1.6.0 stable. No runtime behaviour change for existing tools.
Changes
1. Harden
DESTRUCTIVE_TOOLSagainst future driftWas a hardcoded
Setof 7 names insrc/server/register-tool.ts. If someone adds a newdelete_Xtool but forgets to update the Set, it ships as a routine write — no client confirmation prompt for a destructive operation. The aggregate-count test would catch the drift, but the failure mode is exactly the kind of surprise the annotations were supposed to prevent.Switched to
delete_prefix + 2 explicit non-delete exceptions (remove_track,remove_additional_party). Futuredelete_Xtools auto-inheritdestructiveHint: true. New test pins the safety net.2. Enrich
glama.jsonfor the registry cardWas just
{ maintainers: ["arapov"] }. Now includesdescription+categoriesso glama.ai's listing scrape has actual content for the tile.3. README at-a-glance mention of annotations
The auto-approval improvement landed in rc.3 but didn't make the at-a-glance bullet list. Added one-line callout.
Test plan
npm run typecheckcleannpm run lintcleannpm run format:checkcleannpm test— 469 / 469 (was 468 + 1 new delete_* safety-net assertion)npm run build—dist/index.js 147.44 KB,dist/http.js 173.91 KB(unchanged)After this merges I'll stop. You review master, then say "release" when ready and I'll cut v1.6.0 stable.
🤖 Generated with Claude Code