Repository navigation
search: one global connection search, as a floating overlay on every page - #279
Draft
jseifeddine wants to merge 9 commits into
Draft
jseifeddine wants to merge 9 commits into
jseifeddine wants to merge 9 commits into
Conversation
jseifeddine
force-pushed
the
feat/global-connection-search
branch
2 times, most recently
from
October 13, 2026 06:42
2549670 to
947511d
Compare
…ion feedback connections: sticky self-scrolling sidebar, flush-left folder rows (sol1#254) With 20+ customer folders the sidebar shared the page scroll with the entries table, so picking a folder far down the list changed content off screen, and every leaf row was pushed ~90px in by a hidden chevron placeholder while names were ellipsised. - .sidebar is position: sticky with its own thin scrollbar and max-height tied to the viewport; .main keeps scrolling with the page. - The FOLDERS header is wrapped in .sidebar-pin together with a new empty #sidebar-tools slot, both pinned at the top of the sidebar. - buildFolderNode() renders a .tree-chevron only for folders with children; leaves get no placeholder (removed the .tree-chevron.leaf rule), so rows start right after the 3px accent bar. - Name, entry-count pill (.folder-count, now just the number with a data-count attribute and "N entries" title) and a smaller scope glyph share one line; description sits beneath at --fz-xs; rows are ~40px. - Nested .tree-children indent 14px behind the existing dashed guide. All new CSS is in one block at the end of the page's <style>. connections: selection feedback and in-place sidebar updates (sol1#254) With a long folder list, clicking a folder appeared to do nothing: the entries table was off screen, the only loading state was a text swap, and nothing drew the eye to the changed title. loadEntries() also called renderFolders() just to update one count badge, rebuilding the whole sidebar on every click. - Jump to the entries header when the shown folder changes (smooth, 'auto' under prefers-reduced-motion); never on initial load, live refresh, forceRefresh after a mutation or search clear. - .changed on #entries-header replays a 350ms title slide-in and an accent underline flash on the action bar; cleared on animationend. - Skeleton table (4 shimmering rows, same geometry as the real table) while entries are fetched from the server; the cached path renders immediately with no skeleton. - updateFolderCount() swaps the number in the existing .folder-count badge in place; renderFolders() only as a fallback when the badge does not exist yet. - renderFolders() is wrapped (not edited) to preserve the sidebar scroll position across rebuilds and to reveal the selected row within the sidebar (nearest, no page scroll) when the selection changes or after loadFolders() rebuilds the tree. tests: sidebar scrolls on its own, selected folder marked and kept in view (sol1#254)
connections: folder filter box, keyboard tree navigation and ARIA roles (sol1#254) The sidebar lists one folder per customer and gets long. Add a live filter box (name, path, description; loaded subfolders included, with ancestors of a match kept visible) mounted in a new #sidebar-tools div, persisted in sessionStorage so live refreshes keep it. Make the tree keyboard-navigable (arrows, Home/End, Enter/Space, Left/Right to collapse/expand) with role=tree/treeitem, aria-selected/expanded and a roving tabindex, and add an 'f' shortcut that mirrors the '/' one. Implemented by post-processing the DOM renderFolders() builds and by wrapping that function; its body is unchanged. tests: folder filter box, ARIA tree and keyboard navigation (sol1#254)
…sublines The sticky sidebar was sized from the viewport rather than from where it starts under the header, so at the top of the page its bottom hung off screen and the page had to be scrolled before the list could be scrolled to its end. The page is now an app shell: the header stays, and the sidebar and the entries area are two independent scroll panes that always fit the viewport. Selecting a folder scrolls the entries pane, not the page. The sidebar is a bordered panel: one pinned header band on a surface tone with the Folders label, a compact new-folder button and the filter box, then the list with hairline dividers, 46px rows and one 12px edge for every band. "host (Tenant)" names read as the host over a quieter tenant line in the entries and search tables, and a role-gate reconciliation covers API-key users. Part of sol1#254 connections: scroll only the entries pane on selection, clip the body jumpToEntriesHeader() used scrollIntoView(), which scrolls every scrollable ancestor, and a body with overflow hidden can still be scrolled by script: selecting a folder pushed the brand row and the nav off the top of the page. Scroll the entries pane to its top instead, and make the body overflow: clip, which no script can scroll. The body's border box now spans the full height so the page padding stays inside the viewport. Part of sol1#254 tests: app shell with two independent scroll panes and a clipped body (sol1#254)
…o the served page pages: bake the caller's role into the served page, version the logo The header flashed on every navigation: gated links (Sessions, Reports, Tokens, Admin) were hidden in the markup and shown after /api/me answered, the logo was revalidated on each page load, and the nav differed between pages, so switching tabs reflowed the header. Serve each page in five variants, one per role level, that differ only in a data-role-level attribute on <html>; optional auth now runs on the page routes so a logged-in request gets its variant with the navigation already right on first paint. The ETag is per variant. The logo joins scripts and stylesheets in content-addressed, immutable caching. Part of sol1#254 pages: one navigation for every page, gated by role in CSS Every page carries the same eight links in the same order, including the Credentials entry (which opens the dialog on the connections page and deep-links to it from elsewhere), with data-min-role on the gated ones instead of inline display:none. rustguac.css shows them from the data-role-level the server writes on <html>; the pages set that attribute themselves from /api/me for API-key users, whose page GET carries no credential. Admin-only controls follow the same gate, so nothing pops in after the first paint. Recordings shows "host (Tenant)" entry names as the host over a quieter tenant line. Part of sol1#254 tests: one navigation on every page, gated by data-role-level
The ad-hoc session form sat in a collapsible framed box above the session list. It now opens as a modal from a button on the right of the Sessions heading, dropping the page's framed form box inside the dialog, with the primary button first and Cancel at the same height as Connect, matching the other modals. Section headings centre their heading and action button on one line. Part of sol1#254 tests: the ad-hoc session form opens as a modal (cherry picked from commit 872cc61)
reports: show entry names as host over a tenant subline Session history and the most-used table showed "host (Tenant)" names wrapped across three lines; they now read as the host over a quieter tenant line, as on Connections and Recordings. Part of sol1#254 sessions, recordings: show the session type with the shared badge (sol1#254) The sessions page printed the type as plain text and the recordings page as a coloured word; connections and reports already used .type-badge from rustguac.css. All four now use the same badge. The Proxmox badge colour moves into the shared stylesheet with the others. Shared facet filters (static/filters.js) on the sessions, recordings, reports and connections pages: a dropdown per facet (Type, Folder, User, Owner, Status as each page has them), multi-select with counts that narrow as other facets apply, All/None, a find box for long lists, a Clear filters link, and selections kept per page in sessionStorage. They sit beside the existing text search and combine with it; the buttons are compacted to the height and padding of the other controls and the dropdown reserves room for its scrollbar so it no longer sits over the counts. The list pages share one toolbar: a borderless row with the search box, the facets and the page action on the right (New ad-hoc session, Export CSV), placeholders standardised to 'Search <noun> (fields…)'. Sessions gains a search (user, host, owner, ID, type) and a User facet; Reports moves from its own .filter-bar to the shared one. The redundant page titles go — the nav already names and marks the active page — and section headings centre their heading and action button on one line. Connections: the folder header is sticky at the top of the entries pane, so it stays under the nav and the active-sessions strip while a long table scrolls. All four pages show the session type with the shared .type-badge (the Proxmox colour moves into rustguac.css), reports and recordings show "host (Tenant)" names as the host over a quieter tenant line, and the key glyph before Credentials in the nav is sized to the text. Part of sol1#254 tests: shared facet filters and the list toolbar on every list page
folders: optional display name in the folder config (sol1#254) A folder can carry a display_name beside its description. It is stored in the Vault .config (omitted when empty, so existing configs are unchanged), returned in folder listings and GET .../config, and accepted by POST /api/addressbook/folders and PUT .../folders/:scope/:folder. The NetBox tenant sync sets it to the tenant name, so the connections page can show 'Dani & Fiori's Gourmet Pizzeria' over the folder key instead of three spellings of the tenant in one line. A folder can carry a display_name beside its description. It is stored in the Vault .config (omitted when empty, so existing configs are unchanged), returned in folder listings and GET .../config, accepted by POST /api/addressbook/folders and PUT .../folders/:scope/:folder, and carried in the search index as folder_display_name so results can show it the way the folder view does. The NetBox tenant sync sets it to the tenant name. On the connections page a folder with a display name shows it as the title with the folder key as a sub-header, in the header and the sidebar, so 'Dani & Fiori's Gourmet Pizzeria' reads over the key instead of three spellings of the tenant in one line. The folder modal gets a Display name field, asked for before the description. Part of sol1#254 tests: folder display name is optional in storage and shown over the key A legacy .config without display_name loads with an empty one and is stored unchanged; a set name round-trips. The browser spec checks the header, the sidebar and the folder modal field.
static/ui.js provides promise-based rgConfirm/rgAlert that show a themed modal matching the app, injected self-contained so it works on any page including the standalone client. Every native alert()/confirm() is replaced: delete user and revoke token (admin), revoke token (tokens), delete recording (recordings), popup-blocked (client), and terminate session, delete entry, delete folder and the SSH host-key probe (connections). Destructive actions get a red confirm button, the host-key trust prompt an accent one. From an independent review of the module: rgConfirm/rgAlert resolve any already-open dialog before replacing it, so a second call can't leave the first promise hanging; Enter acts on the focused button (Cancel cancels), and Tab is trapped between the two buttons. Part of sol1#254 tests: themed confirm/alert dialogs replace the native ones (cherry picked from commit 58b1e2e)
…page The '/' search box leaves the connections folder header for a bigger, centred box in the brand row, inline with the logo. Results open in a dim, blurred overlay over an untouched folder view: a centred panel with the summary, the Type and Folder facets and the results table (fixed columns, one line per cell, folder shown by display name over its key, Connect, new window and open-folder gathered into one actions cell). Focusing the box or pressing / opens it and lists every connection the user can see; typing narrows it; Escape from anywhere, a mousedown outside the box and panel, or opening a folder closes it (an open facet menu takes the first Escape). static/search.js is the single implementation, used on every page including connections, which dropped ~16k of duplicated markup, CSS and JS; the styles live once in rustguac.css so the results look identical everywhere. The index is cached in sessionStorage and only re-fetched when the address book's version changes, so moving between pages is instant; the connections page keeps the folder-specific hooks it needs (rgSelectFolder selects a folder in place, rgSearchIndex feeds the credentials banner) and opening a folder from another page navigates to connections with #open=scope/path. The session type is escaped before it becomes a badge class, and the module stands down cleanly on a page with no brand row. Connections also gets a more generous content gutter, the folder action buttons move down to the filter row beside Type, the folder title is inset to align with the table, and the Connect button keeps its size and spins in place instead of growing to 'Connecting...'. Part of sol1#254 tests: the global search overlay on every page search: keep page modals above the brand-row search box The global search lifts the brand row to z-index 300 so the box is not dimmed by its own results overlay (200), but the page modals sat at 100, so the search input showed through the ad-hoc session dialog and could still be focused. Modal overlays now sit at 1000, above the search chrome and below the themed dialogs (4000) and the embedded session (5000). A spec pins it on the ad-hoc and folder modals. search: never on the login page, nor for anyone the server does not recognise The global search was included on index.html, so the login page carried the search box, and because the index was cached in sessionStorage it kept answering with the whole address book after logout, or to the next login in the same tab. - index.html no longer loads search.js at all. - search.js only renders for an operator or above: the role the server bakes on <html data-role-level> decides on first paint, and an API-key user (served the anonymous variant) is confirmed through /api/me first. Anonymous or viewer: nothing injected, cache swept. - The cached index is keyed to the identity /api/me returns; a cache left by a different login is dropped rather than shown. - A 401/403 from the index or version endpoints removes the box, the overlay and the cache; the logout link clears the cache before the login page shows. e2e: login page has no box and never loads search.js; anonymous and viewer callers get nothing and a stale cache is wiped; a different login's cache is dropped; the same login keeps its cache across pages; logout and expiry forget it.
jseifeddine
force-pushed
the
feat/global-connection-search
branch
from
October 13, 2026 07:05
947511d to
f4ad005
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on #277 (
feat/folder-display-name) and #278 (feat/themed-dialogs); its own change is the last commit, the compare on the fork: jseifeddine/rustguac@feat/themed-dialogs...feat/global-connection-search. The branch carries #271–#278 until they merge intomain, so the Files tab shows them too.Fixes #263. Uses the folder display name from #277. Works with or without #270's change counter: without it the index is loaded fresh on each page and not polled.
static/search.json every page: box in the brand row, dim blurred overlay with summary, Type and Folder facets and results over an untouched folder view;/opens, Escape/backdrop/open-folder close; index cached by address-book version; one implementation also used on connections (~16k of duplicated markup removed). Includes the fix that keeps page modals above the search box.Only for the signed in. The box was also on the login page (
index.htmlloadedsearch.js), and the index cached in sessionStorage kept answering with the whole address book after logout or to the next login in the same tab. Now: the login page never loads it;search.jsrenders only for an operator or above by the role the server bakes on<html data-role-level>(API-key users are confirmed through/api/mefirst); the cache is keyed to the identity/api/mereturns and dropped on a different login, on logout, and on any 401/403 from the search endpoints, which also remove the box.Testing
global-search.spec.mjs(including the login page, anonymous and viewer callers, a stale cache from another login, logout, expiry, and a server without the change counter),search-under-modals.spec.mjs./, type a host, Connect: the client opens; on Connections the folder you were in is untouched when the overlay closes; open the ad-hoc dialog on Sessions: the search box is under it.