makefile: Don't powerset with all-targets#189
Merged
joncinque merged 1 commit intosolana-program:mainfrom Mar 10, 2026
Merged
Conversation
#### Problem The powerset check is a bit useless because it enables `--all-targets`, which includes dev-dependencies, which can often enable additional features. #### Summary of changes Remove `--all-targets` from the powerset job.
grod220
approved these changes
Mar 10, 2026
Contributor
|
We probably want to do the same on the SDK, right? https://github.com/anza-xyz/solana-sdk/blob/master/scripts/check-hack.sh#L8 |
Contributor
Author
|
I think that check is ok since the powerset check doesn't enable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The powerset check is a bit useless because it enables
--all-targets, which includes dev-dependencies, which can often enable additional features.Summary of changes
Remove
--all-targetsfrom the powerset job.