Upgrade min flutter sdk to 3.27.0 and min dart sdk to 3.0.0 #91
Conversation
chore!: upgrade minimum dart sdk version to 3.0.0 chore: migrate from Color.withOpacity to Color.withValues(alpha: alpha)
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @andrew-bekhiet-solid, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on updating the minimum required SDK versions for the project. It upgrades the minimum Flutter SDK to 3.27.0 and the minimum Dart SDK to 3.0.0, which are breaking changes. A minor code adjustment was also made to align with potential API changes in the newer SDKs.
Highlights
- Minimum SDK Version Bump: The project now requires Flutter SDK version 3.27.0 or higher and Dart SDK version 3.0.0 or higher. This is a significant breaking change.
- API Adaptation: A minor code modification was implemented in language_tool_controller.dart to use Color.withValues instead of Color.withOpacity for setting color alpha, adapting to potential API changes or improvements in the upgraded Flutter SDK.
- Changelog Documentation: The CHANGELOG.md file has been updated to clearly document the new minimum SDK requirements as breaking changes.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request correctly updates the minimum required Flutter and Dart SDK versions in pubspec.yaml and documents this breaking change in CHANGELOG.md. However, there is a critical issue in lib/src/core/controllers/language_tool_controller.dart where an attempt to replace the deprecated withOpacity method resulted in using a non-existent method withValues. This will cause a compilation error. I have provided a code suggestion to use the correct withAlpha method as recommended in the Flutter documentation.
2 participants
No description provided.