Skip to content

Feature/add permissions column#62

Open
jannesklee wants to merge 10 commits into
solid:mainfrom
jannesklee:feature/add_permissions_column
Open

Feature/add permissions column#62
jannesklee wants to merge 10 commits into
solid:mainfrom
jannesklee:feature/add_permissions_column

Conversation

@jannesklee
Copy link
Copy Markdown

Adds an optional toggle to show permissions. It is color coded and shows the 4 categories

Private/Green
Public/Red
Authenticated/Yellow
Shared/Purple

Hovering over the permissions give additional informations like the detailed webids or URIs.

image image

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 6, 2026

@jannesklee is attempting to deploy a commit to the Solid ODI's projects Team on Vercel.

A member of the Team first needs to authorize it.

@jeswr
Copy link
Copy Markdown
Member

jeswr commented Apr 6, 2026

Couple of quick comments:

  • I would suggest hiding this feature in a settings menu rather than having a top-level toggle. Reason: No other drive style (e.g. GDrive, OneDrive) do not have this feature, so I do not see the majority of users wanting to enable this.
  • It is unclear how complex permissions are displayed, what happens if some people have read access and others have write access. How is this displayed?
  • Do you have an error mode when there is a complex statement you cannot parse?

@jannesklee
Copy link
Copy Markdown
Author

jannesklee commented May 20, 2026

Hi Jesse,

sorry for the (very) late reply..

Although I don't feel expert enough and its not my package, I would like to state my opinion on it if thats ok, especially to the first point 😅

A comparison to GDrive or OneDrive is (maybe) good from a useability view, but I also think the following

  • If not stated otherwise your personal cloud storage is typically always private unless you explicitely define its a shared folder. Its typically not public. Thats easy to remember.
  • For the PODs you also allow apps to write inside and this makes it harder to follow which access rights the data have. I think this is an important point to have it more visible.
  • Additionally, Pod data tends to be by nature "more private", because its maybe not primarily a pdf that you want to have accessible, but personal health data, etc. that is written by the apps (at least this is what I think about) and was formely stored by someone else for you.

That's why I think its important to have the permissions rather visible and prominent then hidden. Of course if you prefer it hidden its also good for me and will change it.

Multiple permissions are shown side by side. When you hover over shared entries, it shows the webids with which the entry is shared.
image
image

I don't have a real error mode and it was hard for me to run the test data environment to be honest (I used it on an own test pod). I finally made it run, but if here are some guidelines from your side I would be happy to follow those.
Currently a file with a mal-formed acl is shown like below
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants