upgrade: keyboard package upgrade for Solid 2.0#854
Draft
davedbase wants to merge 1 commit intosolidjs-community:nextfrom
Draft
upgrade: keyboard package upgrade for Solid 2.0#854davedbase wants to merge 1 commit intosolidjs-community:nextfrom
davedbase wants to merge 1 commit intosolidjs-community:nextfrom
Conversation
🦋 Changeset detectedLatest commit: d2e5c43 The changes in this PR will be included in the next version bump. This PR includes changesets to release 50 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
solid-js@^2.0.0-beta.10and@solidjs/web@^2.0.0-beta.10isServerimport fromsolid-js/web→@solidjs/webuseKeyDownList(the[keys, { event }]destructuring form)useKeyDownSequence—createMemosecond arg is now options in Solid 2.0, soprevstarts asundefined; handle withprev ?? []createShortcutto use fully self-contained imperative state instead of reading reactive signals from event listeners (signal reads outside reactive computations return the pre-batch committed value in Solid 2.0, so shortcut detection andpreventDefaultmust be synchronous/imperative)createKeyHold'spreventDefaultside effect out ofcreateMemointo a dedicatedkeydownlistener (memos must not have side effects in Solid 2.0)INTERNAL_OPTIONS({ ownedWrite: true }) to signals written inside singleton roots to satisfy the owned-scope write restrictiontest/server.test.tscovering all six exported primitives under SSR conditionsflush()after dispatching keyboard events (Solid 2.0 batches signal writes;flush()commits them before assertions)