WIP: Solid 2 site migration — bump router/start, swap solid-js/web#865
Open
brenelz wants to merge 2 commits intosolidjs-community:nextfrom
Open
WIP: Solid 2 site migration — bump router/start, swap solid-js/web#865brenelz wants to merge 2 commits intosolidjs-community:nextfrom
brenelz wants to merge 2 commits intosolidjs-community:nextfrom
Conversation
brenelz
commented
May 4, 2026
brenelz
commented
- Bump @tanstack/solid-router/start to 2.0.0-beta.17/.18 and vite-plugin-solid to 3.0.0-next.5
- Add @solidjs/web@2.0.0-beta.10 and alias solid-js/web → @solidjs/web for transitive deps
- Replace Suspense/ErrorBoundary with Loading/Errored, HydrationScript from @solidjs/web
- Temporarily stub Header, Footer, SolidBlocksHeaderClusterDefs to bypass workspace packages still on Solid 1 APIs (onMount, createComputed, etc.)
- Add minimal /test route for smoke-testing — renders successfully on Solid 2
- Root route still hits a removed createComputed import from a transitive workspace dep
…@solidjs/web, stub Header/Footer - Bump @tanstack/solid-router/start to 2.0.0-beta.17/.18 and vite-plugin-solid to 3.0.0-next.5 - Add @solidjs/web@2.0.0-beta.10 and alias solid-js/web → @solidjs/web for transitive deps - Replace Suspense/ErrorBoundary with Loading/Errored, HydrationScript from @solidjs/web - Temporarily stub Header, Footer, SolidBlocksHeaderClusterDefs to bypass workspace packages still on Solid 1 APIs (onMount, createComputed, etc.) - Add minimal /test route for smoke-testing — renders successfully on Solid 2 - Root route still hits a removed createComputed import from a transitive workspace dep
|
brenelz
commented
May 4, 2026
| ); | ||
| }; | ||
|
|
||
| const Footer: Component = () => null; |
Author
There was a problem hiding this comment.
mocked this for now. Can revert after
brenelz
commented
May 4, 2026
| @@ -0,0 +1,9 @@ | |||
| import { createFileRoute } from '@tanstack/solid-router' | |||
|
|
|||
| export const Route = createFileRoute('/test')({ | |||
Author
There was a problem hiding this comment.
sample route that renders with v2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.