upgrade: cursor package upgrade for Solid 2.0#869
Draft
davedbase wants to merge 1 commit intosolidjs-community:nextfrom
Draft
upgrade: cursor package upgrade for Solid 2.0#869davedbase wants to merge 1 commit intosolidjs-community:nextfrom
davedbase wants to merge 1 commit intosolidjs-community:nextfrom
Conversation
🦋 Changeset detectedLatest commit: 8cfd3f8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solid 2.0 migration
createEffectupdated to the splitcompute/applymodel — cleanup is returned fromapplyinstead ofonCleanupisServerimport moved fromsolid-js/web→@solidjs/webflush()aftercreateRootand each signal write, since Solid 2.0 defers effects by defaultsolid-js@^2.0.0-beta.10+@solidjs/web@^2.0.0-beta.10New primitives
makeBodyCursor(cursor)/makeElementCursor(target, cursor)— imperative, non-reactive; call anywhere, get a cleanup function back.makeBodyCursordelegates tomakeElementCursor(document.body, cursor)to avoid duplicationcreateDragCursor(target, options?)— sets"grab"on the element and switches to"grabbing"on the body during drag. The body-targeting trick is necessary because element inline styles beat body inline styles even with!important, so the element cursor is cleared during drag to let the body cursor inherit throughcursorRef(cursor)— ref factory for<div ref={cursorRef("pointer")}>, accepts a static value or signal