Skip to content

Switch to standardrb#6421

Open
AlistairNorman wants to merge 13 commits intosolidusio:mainfrom
SuperGoodSoft:standardrb
Open

Switch to standardrb#6421
AlistairNorman wants to merge 13 commits intosolidusio:mainfrom
SuperGoodSoft:standardrb

Conversation

@AlistairNorman
Copy link
Contributor

@AlistairNorman AlistairNorman commented Feb 26, 2026

Summary

This builds off of #6241

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@github-actions github-actions bot added changelog:solidus_api Changes to the solidus_api gem changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem changelog:solidus_sample Changes to the solidus_sample gem changelog:solidus Changes to the solidus meta-gem changelog:solidus_admin changelog:solidus_legacy_promotions Changes to the solidus_legacy_promotions gem changelog:solidus_promotions Changes to the solidus_promotions gem labels Feb 26, 2026
@jarednorman
Copy link
Member

This only fixes the issues that could be automatically fixed. There's still a handful of things that couldn't be automatically addressed.

Copy link
Contributor

@mamhoff mamhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change, and I think it sets us up on a good track. Why not mark it as ready for review?

@jarednorman
Copy link
Member

I just bugged @AlistairNorman to get this wrapped when he has time. Would love to see this put to bed once and for all.

@AlistairNorman
Copy link
Contributor Author

I'll definitely work on it but there are 94 offences that can't be automatically corrected

@codecov
Copy link

codecov bot commented Mar 17, 2026

Codecov Report

❌ Patch coverage is 95.47872% with 17 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.66%. Comparing base (0994f63) to head (453e8fc).

Files with missing lines Patch % Lines
...erators/solidus_admin/install/install_generator.rb 0.00% 4 Missing ⚠️
.../controllers/solidus_admin/addresses_controller.rb 57.14% 3 Missing ⚠️
...app/controllers/solidus_admin/orders_controller.rb 75.00% 2 Missing ⚠️
...omponents/solidus_admin/products/show/component.rb 0.00% 1 Missing ⚠️
...onents/solidus_admin/stock_items/edit/component.rb 0.00% 1 Missing ⚠️
...n/ui/forms/address/fieldsets/location/component.rb 0.00% 1 Missing ⚠️
...mponents/solidus_admin/ui/pages/index/component.rb 94.44% 1 Missing ⚠️
...lidus_admin/users/store_credits/index/component.rb 66.66% 1 Missing ⚠️
.../controllers/solidus_admin/customers_controller.rb 66.66% 1 Missing ⚠️
.../app/controllers/spree/api/checkouts_controller.rb 83.33% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6421   +/-   ##
=======================================
  Coverage   89.66%   89.66%           
=======================================
  Files         990      990           
  Lines       20798    20792    -6     
=======================================
- Hits        18649    18644    -5     
+ Misses       2149     2148    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mamhoff
Copy link
Contributor

mamhoff commented Mar 18, 2026

I'll definitely work on it but there are 94 offences that can't be automatically corrected

Just put them into the ignore/to-do file for now. They can be corrected later!

@jarednorman jarednorman force-pushed the standardrb branch 3 times, most recently from 412bb5f to c6ddf0c Compare March 19, 2026 18:55
AlistairNorman and others added 10 commits March 24, 2026 23:45
Co-Authored-By: Jared Norman <jared@super.gd>
Co-Authored-By: Chris Todorov <chris@super.gd>
Co-Authored-By: Senem Soy <senem@super.gd>
Co-Authored-By: Adam Mueller <adam@super.gd>
Co-Authored-By: Noah Silvera <noah@super.gd>
Co-Authored-By: Jared Norman <jared@super.gd>
Co-Authored-By: Chris Todorov <chris@super.gd>
Co-Authored-By: Senem Soy <senem@super.gd>
Co-Authored-By: Adam Mueller <adam@super.gd>
Co-Authored-By: Noah Silvera <noah@super.gd>
These changes have been reviewed individually to ensure these are safe.

Co-Authored-By: Jared Norman <jared@super.gd>
Co-Authored-By: Chris Todorov <chris@super.gd>
Co-Authored-By: Senem Soy <senem@super.gd>
Co-Authored-By: Adam Mueller <adam@super.gd>
Co-Authored-By: Noah Silvera <noah@super.gd>
Standard wants the shared logic out of both branches, but the condition
mutates the order, so the sequence matters.

Co-Authored-By: Alistair Norman <alistair@super.gd>
Co-Authored-By: Chris Todorov <chris@super.gd>
Co-Authored-By: Adam Mueller <adam@super.gd>
Co-Authored-By: Jared Norman <jared@super.gd>
Co-Authored-By: Chris Todorov <chris@super.gd>
Co-Authored-By: Senem Soy <senem@super.gd>
Co-Authored-By: Adam Mueller <adam@super.gd>
Co-Authored-By: Noah Silvera <noah@super.gd>
These do need to be or equals so that we don't overwrite these if people
have changed them.

Co-Authored-By: Jared Norman <jared@super.gd>
Co-Authored-By: Chris Todorov <chris@super.gd>
Co-Authored-By: Senem Soy <senem@super.gd>
Co-Authored-By: Adam Mueller <adam@super.gd>
Co-Authored-By: Noah Silvera <noah@super.gd>
This isn't from Standard. Alistair just likes it better. (So does
everyone else.)

Co-Authored-By: Alistair Norman <alistair@super.gd>
Co-Authored-By: Chris Todorov <chris@super.gd>
Co-Authored-By: Adam Mueller <adam@super.gd>
Co-Authored-By: Alistair Norman <alistair@super.gd>
Co-Authored-By: Chris Todorov <chris@super.gd>
Co-Authored-By: Adam Mueller <adam@super.gd>
Co-Authored-By: Alistair Norman <alistair@super.gd>
Co-Authored-By: Chris Todorov <chris@super.gd>
Co-Authored-By: Adam Mueller <adam@super.gd>
Co-Authored-By: Alistair Norman <alistair@super.gd>
Co-Authored-By: Chris Todorov <chris@super.gd>
Co-Authored-By: Adam Mueller <adam@super.gd>
jarednorman and others added 2 commits March 24, 2026 23:46
Co-Authored-By: Alistair Norman <alistair@super.gd>
Co-Authored-By: Chris Todorov <chris@super.gd>
Co-Authored-By: Adam Mueller <adam@super.gd>
Co-Authored-By: Alistair Norman <alistair@super.gd>
Co-Authored-By: Chris Todorov <chris@super.gd>
Co-Authored-By: Adam Mueller <adam@super.gd>
Co-Authored-By: Alistair Norman <alistair@super.gd>
Co-Authored-By: Chris Todorov <chris@super.gd>
Co-Authored-By: Adam Mueller <adam@super.gd>
@AlistairNorman AlistairNorman marked this pull request as ready for review March 25, 2026 06:56
@AlistairNorman AlistairNorman requested a review from a team as a code owner March 25, 2026 06:56
@tvdeyen tvdeyen mentioned this pull request Mar 25, 2026
6 tasks
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:solidus_admin changelog:solidus_api Changes to the solidus_api gem changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem changelog:solidus_legacy_promotions Changes to the solidus_legacy_promotions gem changelog:solidus_promotions Changes to the solidus_promotions gem changelog:solidus_sample Changes to the solidus_sample gem changelog:solidus Changes to the solidus meta-gem

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

4 participants