Skip to content

Subscriptions currently failing on sqlite after latest changes to promotion system #311

Description

@fthobe

Hey @mamhoff

@shahmayur001 fixed the tests and made the gem work with 4.x on starter frontend, but it seems there are some issues with the new promotion system on 4.4.2 (4.4.1 did install and function correctly).

We are experiencing some issues with:

  1. installing on solidus with the new promotion gem
  2. tests are failing again after they worked (more or less flawlessly) on PR

Can you help us to wrap this up and make it all work so that @jarednorman and @kennyadsl can wrap it up into a release?

@shahmayur001 please post the error messages.

Solidus Version:
4.4.2

To Reproduce
Install current subscription main gem over 4.4.2.

image

Activity

  1. added
    bugDescribes or fixes a bug.
    on Jan 2, 2025
  2. fthobe commented on Jan 2, 2025

    @fthobe
    Author

    Installation Issues

    image (1)
    image (2)

  3. changed the title [-]Subscriptions currently failing after latest changes to promotion system[/-] [+]Subscriptions currently failing on sqlite after latest changes to promotion system[/+] on Jan 10, 2025
  4. fthobe commented on Feb 3, 2025

    @fthobe
    Author

    @shahmayur001 this is resolved, correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugDescribes or fixes a bug.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions