Conversation
Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SOU-2308
Require authenticated users for the streaming and blocking Ask APIs when
EXPERIMENT_ASK_GH_ENABLEDis enabled, while preserving anonymous Ask behavior for self-hosted deployments. Centralize the policy and apply it to the MCP HTTP entry point as well.Validation:
Linear Issue: SOU-2308
Summary by cubic
Fixes SOU-2308 by requiring authenticated users for the streaming and blocking Ask APIs and MCP HTTP entry point when the Public SaaS experiment is enabled. Anonymous Ask access remains unchanged for self-hosted deployments. The auth check is centralized in
checkAskAuthenticationand applied to all three entry points, and the CHANGELOG records the change.Written for commit 0653cce. Summary will update on new commits.