Conversation
Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
…ch-ask-gh-ca5f Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>
Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>
Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>
…ch-ask-gh-ca5f # Conflicts: # CHANGELOG.md Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>
Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>
Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>
Co-authored-by: Michael Sukkarieh <msukkari@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes SOU-2307
Summary
EXPERIMENT_ASK_GH_ENABLED=trueand the user is anonymous.isAuthenticated/isLoginWallEnabledcontract, sharedLoginDialog, empty-submission behavior, andwa_askgh_login_wall_promptedevent.E2E matrix
Tested the final changed branch at
81846d3b. For regression comparisons, tested the exact pre-change baseline ata28b1812with the same indexed repository, database, and action sequence.Ask GH on + anonymous access enabled
/search: anonymousSearchBarsubmission openedSign in to continue; after credentials login, the browser automatically reached/search?query=SearchBarand rendered results without query re-entry.SearchBarresults, opened code preview and full file browser, navigated fromlayoutClient.tsxtolayout.tsx, and viewed commit history without a login wall.SearchBartoLoginDialog; login wall appeared over the old results; after login, the browser automatically reached/search?query=LoginDialogand rendered the new results.ask_gh_main_search_login_resume.mp4
ask_gh_anonymous_results_files_history_browse.mp4
ask_gh_result_page_search_login_resume.mp4
final_empty_and_nonempty_search_gate.mp4
Ask GH off + anonymous access enabled
Ran the same script on changed and baseline deployments: anonymous
SearchBarsearch, result preview, full file browser, file-tree navigation tolayout.tsx, history view, andLoginDialogsearch from the result page. Both remained ungated and produced matching behavior.Changed deployment:
changed_flag_off_anonymous_enabled_full_flow.mp4
Pre-change baseline:
baseline_flag_off_anonymous_enabled_full_flow.mp4
Ask GH off + anonymous access disabled
Ran the same script on changed and baseline deployments. Both redirected logged-out
/searchrequests to/loginwith no guest option. After authentication, both completed the same search, preview, file-tree, history, and second-search flow with matching behavior.Changed deployment:
changed_flag_off_anonymous_disabled_full_flow_retry.mp4
Pre-change baseline:
baseline_flag_off_anonymous_disabled_full_flow.mp4
Automated validation
yarn workspace @sourcebot/web lintyarn workspace @sourcebot/web test --run(147 files, 1,503 tests)build,lint,test, OpenAPI generation, CodeQL, and vulnerability checks pass.To show artifacts inline, enable in settings.
Summary by cubic
Gates code search submissions behind a client-side login for anonymous users when
EXPERIMENT_ASK_GH_ENABLED=true, while preserving anonymous access to results and repository browsing.Written for commit e372c86. Summary will update on new commits.