This repository was archived by the owner on Feb 6, 2026. It is now read-only.
Fix: Allow empty result string in reviewDiff validation#8
Open
Felipe-RA wants to merge 1 commit intosourcegraph:mainfrom
Open
Fix: Allow empty result string in reviewDiff validation#8Felipe-RA wants to merge 1 commit intosourcegraph:mainfrom
Felipe-RA wants to merge 1 commit intosourcegraph:mainfrom
Conversation
The reviewDiff function was rejecting valid review completions when the AI agent returned an empty string as the result. This occurred when the agent used only toolbox functions (leave_inline_comment, leave_general_comment) without additional text output. Issue: - Line 81 checked: if (!threadId || !result) - Empty string is falsy in JavaScript, so !result evaluates to true - This caused 'Amp review failed' errors even when review succeeded - Comments are collected via JSONL file, not the result string - The result field is never used after being returned Fix: - Changed to only check: if (!threadId) - Empty result is now valid (AI used tools, no text needed) - Only fails if no thread was created (legitimate error) Evidence: - Tested with 130K+ char diffs that trigger tool-only responses - Verified result field is never accessed in process-review.ts - Build passes, TypeScript compiles successfully This allows reviews to complete when AI agents generate comments via tools without returning additional text in the result field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Solves #7
Problem
The
reviewDifffunction inreviewer.tsrejects valid review completions when the AI agent returns an empty string as the result. This occurs with large diffs (130K+ chars) where the agent uses only toolbox functions (leave_inline_comment,leave_general_comment) without additional text output.Error observed:
Root Cause
Line 81 in
src/review/reviewer.ts:!resultevaluates totrueresultstringresultfield is never used after being returned (verified inprocess-review.ts)Solution
Changed the validation to only check for
threadId:This allows empty result strings (which should be valid when AI uses only tools to write comments) while still catching legitimate errors (no thread created).
Testing
resultfield is never accessed inprocess-review.tsImpact
resultfield is never used after this, so removing the check doesn't break anythingresultin response object