Resolve import aliases as global references instead of local definitions#201
Merged
Resolve import aliases as global references instead of local definitions#201
Conversation
Aliased imports (e.g. h "net/http") now emit a reference to the global package symbol rather than creating a local definition. This means a references lookup from the original package statement returns all individual usages across files (Option A). Removes the pkgNameOverride mechanism entirely since all package name usages in SelectorExpr now resolve directly to the global symbol.
jupblb
force-pushed
the
michal/global-import-alias
branch
2 times, most recently
from
169f479 to
9aff313
Compare
Test cases covering global reference resolution for import aliases: - All import styles: non-aliased, blank, dot, and renamed aliases - Same-name aliases (fmt "fmt") resolve globally - Cross-file alias consistency - References issue #34
jupblb
force-pushed
the
michal/global-import-alias
branch
4 times, most recently
from
cbd3fb0 to
4e7c1ba
Compare
The overrides struct wrapper is unnecessary now that pkgNameOverride has been removed, leaving only caseClauses.
jupblb
force-pushed
the
michal/global-import-alias
branch
from
4e7c1ba to
8c5f3e4
Compare
JamyDev
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For more context see: #197 (comment). Fixes #34.