Skip to content

Make it compile on Alpine#14

Merged
jviotti merged 1 commit intomainfrom
hydra-alpine
Jan 13, 2026
Merged

Make it compile on Alpine#14
jviotti merged 1 commit intomainfrom
hydra-alpine

Conversation

@jviotti
Copy link
Member

@jviotti jviotti commented Jan 13, 2026

Signed-off-by: Juan Cruz Viotti jv@jviotti.com

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
@augmentcode
Copy link

augmentcode bot commented Jan 13, 2026

🤖 Augment PR Summary

Summary: Adjusts the MbedTLS CMake compiler warning flags to build successfully on Alpine.

Changes:

  • Adds -Wno-error=array-bounds so array-bounds warnings don’t fail the build under -Werror.

🤖 Was this summary useful? React with 👍 or 👎

Copy link

@augmentcode augmentcode bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review completed. 1 suggestions posted.

Fix All in Augment

Comment augment review to trigger a new review at any time.

-Wextra
-Wpedantic
-Werror
-Wno-error=array-bounds
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-Wno-error=array-bounds is fairly GCC-specific; without a feature check / compiler gating, this can break builds on toolchains that don’t recognize that warning name (or treat unknown warning options differently). Consider scoping it to the compiler/version that triggers the Alpine issue so -Werror remains effective elsewhere.

Fix This in Augment

🤖 Was this useful? React with 👍 or 👎

@jviotti jviotti merged commit c5f9542 into main Jan 13, 2026
12 checks passed
@jviotti jviotti deleted the hydra-alpine branch January 13, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant