fix#140: ordering of linting errors by source location#141
fix#140: ordering of linting errors by source location#141RitoG09 wants to merge 4 commits intosourcemeta:mainfrom
Conversation
|
The diff is huge, as it seems you are changing formatting/indention of the entire files you touch. Can you configure your editor to follow the current conventions so that the diff only reflects the actual changes? The industry standard out there is EditorConfig (https://editorconfig.org), which you should be able to install on your editor. That will make it follow https://github.com/sourcemeta/studio/blob/main/.editorconfig |
|
I'm also wondering if we can actually do the ordering on the CLI when |
|
I have formatted it using editorconfig in my latest commit, can u check it once? |
@jviotti will work on it and open a PR after 3-4 days as my semester end exams are going on. |
test/vscode/extension.test.ts
Outdated
| }); | ||
|
|
||
| test("Lint diagnostics should be ordered by line number", async function () { | ||
| this.timeout(15000); |
vscode/src/extension.ts
Outdated
|
|
||
| if (lintResult.errors && lintResult.errors.length > 0) { | ||
| // TODO: Consider moving lint diagnostic ordering to the jsonschema CLI | ||
| lintResult.errors = sortLintErrorsByLocation(lintResult.errors); |
|
@jviotti , the ordering is already implemented on CLI by @Karan-Palan . I think we should remove the todo comment. |
We might not need to merge this if ordering works fine on the CLI |
yeah, it makes sense. |
|
Let's merge the CLI PR first. I think we still want this PR, mostly because of the test. |
|
Hey @RitoG09, could you update the PR with keeping just the test and the related schema. Also, sign your commits to pass the DCO |
|
@Karan-Palan I'm traveling right now, will do this by Sunday. |
RitoG09
force-pushed
the
fix/140
branch
2 times, most recently
from
33425e5 to
581bd73
Compare
Signed-off-by: Ritabrata Ghosh <76sonali40@gmail.com>
Signed-off-by: Ritabrata Ghosh <76sonali40@gmail.com>
Signed-off-by: Ritabrata Ghosh <76sonali40@gmail.com>
Signed-off-by: Ritabrata Ghosh <76sonali40@gmail.com>
3 participants
Fixes #140
What have been done
Proof of Action