fix(parser): keep cross-references in initializers - #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #127, reported by @gkodinov.
<initializer>was read as flat text, so every<ref>child was discarded.#define RETRY_HOOK registry->retrycame out as#define RETRY_HOOK ->retry. Initializers now go through the same markdown conversion as every other field.Macros gained initializer rendering in 2.1.13, so they have shown this since then. Variable initializers were affected for longer and are fixed by the same change.
On the follow-up about linking the reference: signatures render inside a ```cpp fence, where
[baz](#baz)stays literal rather than becoming a link. The HTML in the issue is Doxygen's own output, which has no such constraint. So the reference is flattened to its text here, which is what makes the fence read correctly.Covered by a fixture case in
test/fixtures/macrosplus unit tests for both the macro and variable paths.Bundles the 2.1.15 bump, so merging releases it.