fix: nested lists, and a github flavour for admonitions - #133
Merged
Conversation
auscaster
force-pushed
the
fix/lists-and-github-alerts
branch
from
September 1, 2026 03:11
0dcc582 to
bc8418f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the two remaining reports from @gkodinov.
Nested lists (fixes #115)
Both halves of his report, and the ordered-list case he did not mention:
Indentation is measured against the parent item's marker rather than a fixed width, so a list nested under
1.indents three spaces and one under*indents two. That is what Markdown needs to actually nest, and hardcoding two spaces would have quietly broken ordered lists.The three list kinds had three identical case bodies; they are one now.
GitHub alerts (fixes #126)
--flavour githubrenders admonitions as GitHub alerts:@noteand@remarkmap to[!NOTE],@warningto[!WARNING],@attentionto[!IMPORTANT]. Default stayspandocand its output is byte-identical: the two dialects now share one renderer, so the pandoc path could not drift while adding the other.Worth knowing: no fixture had a single admonition, so the
:::notepath had never been rendered by a test. It has coverage in both dialects now.Also note
@deprecatedreaches us as anxrefsectrather than a simplesect, so it still renders as a plain> Deprecated: …blockquote in both flavours. Mapping that would mean matching on a localised title string, which I would rather not build.No version bump. Nothing releases until you say so.