Remove halloween masks and loot box from default scav loadouts

[sgtlaggy]

4.1 scav data appears to have been gathered during the time it was live so halloween loot is included in scav data. This patch removes the masks and pumpkin helmet, which are already present in the seasonal event gear list, as well as the pumpkin loot container, which was not present in event loot but has been added similar to Christmas ornaments.

[acidphantasm]

I would suggest maybe go the other way and handle the removal via the seasonal event service like Christmas items. My 2c

server-csharp/Libraries/SPTarkov.Server.Core/Services/Server/SeasonalEventService.cs

Line 345 in 693fb81

public void RemoveChristmasItemsFromBotInventory(BotTypeInventory botInventory, string botRole)

The whole add/remove part of the service probably needs tuned up a bit tbh

[sgtlaggy]

Took a look at that, it would work but I'm not sure even that one is appropriate. Its purpose is to remove Christmas items from all bots except gifter but only when the Christmas event isn't active. The April Fools event explicitly adds Christmas gear and loot, effectively a null action because that method will later remove it.

IMO removing that method and cleaning event items from the base data is a better option.
Or if we'd like the keep the json as true to the original data as possible, clean up the gear/loot data once at startup instead of on each generated bot? Maybe this could be done in UpdateGlobalEvents where it resets the event active bools, this could also help facilitate disabling events in long-running Fika servers.

[acidphantasm]

Took a look at that, it would work but I'm not sure even that one is appropriate. Its purpose is to remove Christmas items from all bots except gifter but only when the Christmas event isn't active. The April Fools event explicitly adds Christmas gear and loot, effectively a null action because that method will later remove it.

IMO removing that method and cleaning event items from the base data is a better option. Or if we'd like the keep the json as true to the original data as possible, clean up the gear/loot data once at startup instead of on each generated bot? Maybe this could be done in UpdateGlobalEvents where it resets the event active bools, this could also help facilitate disabling events in long-running Fika servers.

I only recommend removing it like the Xmas removal, because cleaning the data manually now.. then getting more data means you just have to clean it again. Removals should happen in code so it always happens on startup IMO

I believe that's why the Christmas removal method exists, so you don't have keep cleaning dumped data but I could be wrong

[refringe]

@acidphantasm is correct here. We tend to not play around with this JSON data directly as it's generated automatically via loot and bot dumps. We either adjust the generation, or adjust how the generated data is used, but never the actual generated data (manually).

[sgtlaggy]

Understood. If I force-push a commit with that RemoveHalloweenItems... method, should I keep the seasonal event config change where I added the pumpkin container?

[refringe]

I'm not well versed in how that config file works... If that config file simply adds those items into the pool when each event is active, I don't think it would be necessary (in this case) as the item is already in the pool. You would just need to make sure that your code is removing them from the pool when the event is not active.

Frankly, I don't love that these seasonal items are in the base generated loot, but I can't see us regenerating the loot to remove them at this point for 4.1. So I think we're safe to move forward with the assumption that they'll remain there.

[sgtlaggy]

That can be added later if necessary. Force-pushed the new commit on its own, copying the use and implementation of RemoveChristmasItemsFromBotInventory.