Skip to content

fix(security): sanitize vector store validation error responses in settings router #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spelech merged 1 commit into from
Sep 27, 2026
Merged

fix(security): sanitize vector store validation error responses in settings router #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions app/api/routers/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,8 @@ async def api_test_vector_store(payload: VectorStoreTestRequest):
try:
safe_sp = _validate_vector_storage_path(payload.storage_path)
except ValueError as ve:
return JSONResponse(status_code=400, content={"success": False, "error": str(ve), "message": str(ve)})
logger.warning(f"Vector store path validation failed: {ve}")
return JSONResponse(status_code=400, content={"success": False, "error": "Invalid storage path: outside authorized directories.", "message": "Invalid storage path: outside authorized directories."})

success, message = vs_service.test_vector_store_connection(
provider=payload.provider,
Expand All @@ -335,7 +336,8 @@ async def api_switch_vector_store(payload: VectorStoreSwitchRequest):
try:
safe_sp = _validate_vector_storage_path(payload.storage_path)
except ValueError as ve:
return JSONResponse(status_code=400, content={"status": "error", "error": str(ve), "message": str(ve)})
logger.warning(f"Vector store path validation failed: {ve}")
return JSONResponse(status_code=400, content={"status": "error", "error": "Invalid storage path: outside authorized directories.", "message": "Invalid storage path: outside authorized directories."})

def _reindex():
threading.Thread(target=idx_service.run_full_indexing, daemon=True).start()
Expand Down
Loading