Golemv2 #1390
Golemv2 #1390
Conversation
This test fails bc the FakeLibrary doesnt actually execute the command. Should I update the test to just check that the eldritch is evaluating or update the FakeLib to run commands? Link to the problem line: |
I would update the test with the info that the command will not actually be executed. |
KCarretto
left a comment
KCarretto
left a comment
There was a problem hiding this comment.
Fix tests and then lgtm. Be sure the regular assets lib still works with imixv2
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
nullmonk
force-pushed
the
golemv2
branch
2 times, most recently
from
9067368 to
654f9e3
Compare
| use alloc::vec::Vec; | ||
| use anyhow::anyhow; | ||
| use core::fmt::Debug; | ||
| use eldritch_libassets::std::AssetBackend; |
There was a problem hiding this comment.
We should re-export this in eldritchv2 instead of requiring callers to import specific standard libraries on top of eldritchv2
| use std::fs; | ||
| use std::path::PathBuf; | ||
|
|
||
| const MAX_RECURSION_DEPTH: usize = 10; |
There was a problem hiding this comment.
We can probably safely make this higher?
| use std::io::{self, Write}; | ||
| use std::time::Duration; | ||
|
|
||
| pub fn repl(mut inter: Interpreter) -> io::Result<()> { |
There was a problem hiding this comment.
We should definitely move this to the repl crate since it's used by 3+ clients now
There was a problem hiding this comment.
can we do that in a separate PR?
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add Golemv2 for use with eldritchv2