Skip to content

Fix finalized journal recovery evidence #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pallyoung merged 1 commit into from
Aug 25, 2026
Merged

Fix finalized journal recovery evidence #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion scripts/verify-desktop-installed-update.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -547,11 +547,16 @@ try {
$restartSidecarUrl = Get-SidecarUrl $restartPages
$sidecarUrl = $restartSidecarUrl
$journalAfter = Read-JournalIdentity $journalPath
# A fully reconciled plan is cleared during startup; the recovered state is
# validated by the driver before this evidence is accepted.
$journalRecovered = $null -ne $journalBefore -and (
$null -eq $journalAfter -or $journalBefore -eq $journalAfter
)
Write-JsonAtomic $controlPath @{
schemaVersion = 1
phase = $control.phase
status = 'relaunched'
journalRecovered = ($null -ne $journalBefore -and $journalBefore -eq $journalAfter)
journalRecovered = $journalRecovered
cdpUrl = "http://127.0.0.1:$cdpPort"
sidecarUrl = $restartSidecarUrl
}
Expand Down
2 changes: 2 additions & 0 deletions scripts/verify-desktop-installed-update.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,6 +155,8 @@ describe("verify-desktop-installed-update", () => {
expect(runner).toContain("$cdpPort = Get-FreeTcpPort");
expect(runner).toContain('cdpUrl = "http://127.0.0.1:$cdpPort"');
expect(runner).toContain("sidecarUrl = $restartSidecarUrl");
expect(runner).toContain("$null -eq $journalAfter -or $journalBefore -eq $journalAfter");
expect(runner).toContain("journalRecovered = $journalRecovered");
expect(runner).toContain("Stop-InstalledDesktopExecutable $Executable $CdpPort");
expect(runner).toContain(
"$lastInstallerCount = @(Get-InstallerProcesses $InstallerFileName).Count"
Expand Down
Loading