feat: parse hexadecimal strings in ToUint64E#344
Closed
leno23 wants to merge 2 commits into
Closed
Conversation
…ions/checkout-6.0.1 build(deps): bump actions/checkout from 5.0.1 to 6.0.1
Fixes spf13#334. When decimal parsing fails, ToUint64E now accepts bare hexadecimal strings (with or without a 0x prefix) for uint64 conversion.
|
|
leno23
force-pushed
the
feat/uint64-hex-string-334
branch
from
7cbdabe to
34c2e65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #334.
ToUint64Enow converts bare hexadecimal strings (e.g.882d5422d5fffff) touint64, in addition to existing decimal and0x-prefixed forms.Test plan
go test -run TestToUint64HexString -vgo test ./...Made with Cursor