-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Update README to clarify HCL, INI, and Java Properties support moved to plugin #2098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
the user to UPGRADE.md Signed-off-by: nook24 <info@nook24.eu>
README.md
Outdated
| * INI | ||
| * envfile | ||
| * Java Propeties | ||
| * HCL (see below) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would add a Markdown link.
Developers are lazy animals for good reasons.
I know it, I'm one of them 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, i will fix this
README.md
Outdated
| > specify the format programmatically, which is useful for files that naturally | ||
| > have no extension (e.g., `.bashrc`). | ||
| > **NOTE (since 1.20)** In order to reduce third-party dependencies, Viper dropped support for the following formats from the core: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use the following syntax maybe
> [!NOTE]
> Blah blahIt would be rendered this way
Note
Blah blah
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently there a multiple, let's call it legacy note blocks. For this reason I decided to use the same way.
I guess it would be good to refactor all of the quote blocks in this case. I can also do this if you like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm a random Gopher here. Keep it as-is and consider refactoring in a later PR if a maintainer is OK about the format
Signed-off-by: nook24 <info@nook24.eu>
|
All done :) |
This PR will improve the README to inform users about the changes related to HCL, INI and Java Properties implemented with Viper 1.20.0 and will resolve #2092
Happy holidays!