Repository navigation
CI: add MSVC build and fix building with MSVC - #907
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Also yeah, MSVC has been broken at least since the github repo got source back in March last year. Personally I would want to just drop support for it entirely because we're in The Future and mingw and docker ain't so bad, but the changes aren't that bad I guess. |
Contributor
Author
|
In that case (and considering nobody else noticed MSVC was broken in over a year), perhaps it's better to eject MSVC considering it introduces extra bugs of its own? Could potentially introduce a new build.ps1/build.bat for windows that uses either the official llvm-mingw toolchain on windows or my hacked up XP version, which is a whole lot easier to understand than docker. |
Contributor
Author
|
Yeah that's fair. In which case, keep it compatible |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yess yessss let's continue supporting the worst compiler toolchain 😈
Fell out of the changes in #905
CI changes were claude because I cannot be arsed with yaml.
Can explain the individual code fixes if ya want any more context.