feat(scripts): bind a published overlay to the CDP run that applied it - #17
Merged
Merged
Conversation
A CDP report that records its overlay digest must match the overlay being published, and a run without one is noted in VERIFICATION.md. Overlays must be in canonical form so the digests compare.
|
Warning Review limit reachedNext included review available in 3 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cssMap.overlaySha256(feat(scripts): verify a key's css-map overlay over CDP cli#3976),publish-keyrequires it to match the overlay being published, so a key can't ship an overlay the live run never applied.VERIFICATION.mdthen notes that the overlay's names weren't checked live.flattenalready writes that form.--overlayto the CDP verifier for both inherited and derived keys.Verification
pnpm checkpasses: tsc, index, validator, expose, and 59 tests. New tests cover a matching overlay digest, a mismatch, a report with no digest, and a non-canonical overlay.