Skip to content

chore(classmap): re-verify 1020099, 1030000 and 1030001 with full deep coverage - #20

Merged
afonsojramos merged 1 commit into
mainfrom
chore/reverify-deep
Sep 30, 2026
Merged

afonsojramos merged 1 commit into
mainfrom
chore/reverify-deep

Conversation

@afonsojramos

Copy link
Copy Markdown
Member

Summary

Re-verified three keys on unpatched clients with the deep CDP run from spicetify/cli#3977, which now opens the context menu, the credits and embed dialogs, and Settings.

Key Build In stock CSS Observed live by stock class Steps
1020099 1.2.99.317 36/36 32/36 10/10
1030000 1.3.0.277 33/36 32/36 10/10
1030001 1.3.1.234 32/36 32/36 10/10
  • 1030000 and 1030001: the track-credits and embed containers and the Settings section move to verified_cdp.
  • 1020099: records its verified classmap digest. settings.header.container moves from unverified to verified_static: its class is in the stock CSS, and the run didn't render that section.
  • Not observed on any of the three builds: the Settings output-device header, and the Encore chip-group classes, which no page uses on these builds.
  • Upgrade button: the leaf stays stale on 1020099. Its generic primary-button classes matched 117 elements, which doesn't establish the upgrade-button role, and VERIFICATION.md records that.
  • The maps and overlays are unchanged, and each VERIFICATION.md keeps its earlier history.

Verification

pnpm check passes.

…p coverage

The deep CDP run now opens the context menu, credits, embed and Settings. On unpatched clients it observes 32/36 leaves with 10/10 steps on each build. The modal and Settings section paths of the 1.3 keys move to verified_cdp, and 1020099 records its verified classmap digest.
@coderabbitai

coderabbitai Bot commented Sep 30, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 47 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 26a8787c-6bd2-4ec4-81b0-a26c71c3f164

📥 Commits

Reviewing files that changed from the base of the PR and between 92c401a and 04f6044.

📒 Files selected for processing (7)
  • 1020099/META.json
  • 1020099/VERIFICATION.md
  • 1030000/META.json
  • 1030000/VERIFICATION.md
  • 1030001/META.json
  • 1030001/VERIFICATION.md
  • index.json

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@afonsojramos
afonsojramos merged commit 3f220d3 into main Sep 30, 2026
2 checks passed
@afonsojramos
afonsojramos deleted the chore/reverify-deep branch September 30, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant