feat(scripts): open an issue when a Linux Spotify build has no classmap - #21
Merged
Merged
Conversation
A daily workflow reads Spotify's apt channels, statically verifies the newest older key against each unpublished build's stock CSS, and opens an issue that says whether to publish an inherited key or migrate.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 10 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/watch-spotify.tsreads Spotify's Linux apt channels (stableandtesting) and finds builds without a published key. For each one it:.deband checks it against the index's SHA-256;xpui.spaand runs the CLI's static verifier with the newest older key's map;.github/workflows/watch-spotify.ymlruns it daily and on demand. It checks out spicetify/cliv3-betafor the verifier, withcontents: readandissues: write. It doesn't open a second issue for a title that already exists.--dry-run --only <key>re-assesses a published build without opening an issue.macOS and Windows builds come from an endpoint that needs a signed-in client, so the job can't see them.
Verification
--dry-run --only 1020096on the real 1.2.96.518 package: 33/36 leaves in the stock CSS. The three missing hashed classes are ones 1020095 already records as stale or unverified, so the verdict is "inherit", which is how 1020096 was published.pnpm checkpasses (66 tests).main. I'll run it once after merging and read the token's permissions from the job header.