Skip to content

fix(css-map): name the now-playing cover art wrapper on 1.3.3 - #25

Merged
afonsojramos merged 1 commit into
mainfrom
fix/now-playing-cover-art-name
Oct 2, 2026
Merged

afonsojramos merged 1 commit into
mainfrom
fix/now-playing-cover-art-name

Conversation

@afonsojramos

@afonsojramos afonsojramos commented Oct 1, 2026 •

Copy link
Copy Markdown
Member

Summary

Spotify 1.3 re-hashed the player bar's cover art wrapper, the element directly around .cover-art. It no longer carries main-nowPlayingWidget-coverArt, so every theme rule written against that name stopped matching, including starry-night, turntable, text and dribbblish (spicetify/modules#38).

The 1.3 overlays are flattened from classmap leaves, and no leaf references this name, so it was never bridged. This adds the missing entry for 1.3.3:

{ "juCqgHeBZkAuaFifkKtx": "main-nowPlayingWidget-coverArt" }

Evidence: on 1.2.97, the call site in dwp-now-playing-bar.js (size:56, maxSize:56, className: …) used lZCogpVJ9VYr762A, which the base css-map names main-nowPlayingWidget-coverArt. On 1.3.3 the same call site uses juCqgHeBZkAuaFifkKtx. That hash appears only there and in one CSS rule (flex-shrink:0; position:relative), so renaming it touches nothing else.

Not included: 1.3.0 (1030000) and 1.3.1 (1030001). I could not get those bundles to confirm their hash, so they have no entry here. The first-party themes also fall back to [data-testid="cover-art-button"] (spicetify/modules PR linked below), which covers those builds.

Validation

  • pnpm check passes, and index.json was rebuilt with pnpm fix.
  • Live on Spotify 1.3.3.264 (macOS arm64), applying with SPICETIFY_CLASSMAPS_DIR pointed at this branch: the overlay applies with 292 entries. .main-nowPlayingWidget-coverArt is back on the element directly inside [data-testid="cover-art-button"] and wraps .cover-art. An unmodified rule .main-nowPlayingWidget-coverArt .cover-art { … } reaches the cover art again.

Summary by CodeRabbit

  • Bug Fixes
    • Updated the styling map for the now-playing cover art, helping the interface apply its intended appearance.

@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

🧰 Additional context used
📚 Code guidelines (1)
AGENTS.md — auto-discovered

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: ef9df2c9-4680-44cd-9bba-77082de42e0f

📥 Commits

Reviewing files that changed from the base of the PR and between efb0755 and 414ea48.

📒 Files selected for processing (2)
  • 1030003/css-map.json
  • index.json

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The CSS map for key 1030003 adds a mapping from juCqgHeBZkAuaFifkKtx to main-nowPlayingWidget-coverArt. The index updates the cssMapOverlay SHA-256 checksum for that key.

Changes

Cover art class mapping

Layer / File(s) Summary
Add class mapping and update checksum
1030003/css-map.json, index.json
The CSS map adds the main-nowPlayingWidget-coverArt mapping. The index records the updated checksum.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: mralimoh

Merge Risk: ⚪ Minimal · up to 414ea

The overlay and index are internally consistent, with no demonstrated merge-blocking issue.

Architecture Summary

Architecture risk: 🔵 Low · up to 414ea

The change affects 2 systems.

Changed systems: 1030003, index.json

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — 1030003 (service) was modified; 1 changed file maps to changed impact.
  • observed — index.json (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in 1030003/css-map.json: Added the mapping from juCqgHeBZkAuaFifkKtx to main-nowPlayingWidget-coverArt.
  • observed — Modified behavior in index.json: The cssMapOverlay SHA-256 for key 1030003 changed from c0c993277547bfc8ec53f4fa0a055c6e6a470dc5dbb38e37e53ed13514f20e01 to 2d1569cc65097aa48b05a32efcb9b85f922be8548b84b1e442ee3cc544eb6f34.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding the CSS map name for the now-playing cover art wrapper in Spotify 1.3.3.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the class-map page
A cover blooms upon the stage
One new name joins the CSS
The checksum follows, nothing less
Then hops away through leafy green

Comment @coderabbitai help to get the list of available commands.

@afonsojramos
afonsojramos merged commit ed4d656 into main Oct 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant