fix(css-map): name the now-playing cover art wrapper on 1.3.3 - #25
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. 🧰 Additional context used📚 Code guidelines (1)No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe CSS map for key ChangesCover art class mapping
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The overlay and index are internally consistent, with no demonstrated merge-blocking issue. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 2 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the class-map page Comment |
Summary
Spotify 1.3 re-hashed the player bar's cover art wrapper, the element directly around
.cover-art. It no longer carriesmain-nowPlayingWidget-coverArt, so every theme rule written against that name stopped matching, including starry-night, turntable, text and dribbblish (spicetify/modules#38).The 1.3 overlays are flattened from classmap leaves, and no leaf references this name, so it was never bridged. This adds the missing entry for 1.3.3:
{ "juCqgHeBZkAuaFifkKtx": "main-nowPlayingWidget-coverArt" }Evidence: on 1.2.97, the call site in
dwp-now-playing-bar.js(size:56, maxSize:56, className: …) usedlZCogpVJ9VYr762A, which the base css-map namesmain-nowPlayingWidget-coverArt. On 1.3.3 the same call site usesjuCqgHeBZkAuaFifkKtx. That hash appears only there and in one CSS rule (flex-shrink:0; position:relative), so renaming it touches nothing else.Not included: 1.3.0 (
1030000) and 1.3.1 (1030001). I could not get those bundles to confirm their hash, so they have no entry here. The first-party themes also fall back to[data-testid="cover-art-button"](spicetify/modules PR linked below), which covers those builds.Validation
pnpm checkpasses, andindex.jsonwas rebuilt withpnpm fix.SPICETIFY_CLASSMAPS_DIRpointed at this branch: the overlay applies with 292 entries..main-nowPlayingWidget-coverArtis back on the element directly inside[data-testid="cover-art-button"]and wraps.cover-art. An unmodified rule.main-nowPlayingWidget-coverArt .cover-art { … }reaches the cover art again.Summary by CodeRabbit