chore: follow the spicetify/classmaps schema 2 layout - #3972
Merged
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: spicetify/cli/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expose.jsonwith refactor: make classmap data consistent, validated and generated classmaps#16, which stores per-build hit counts as ahitsobject and drops$comment. The patterns, templates and flags are unchanged, andPatchSpecignores the extra field.scripts/classmap_e2e.shand theclassmap_capture.pyusage example at1020040/classmap.json, because the hashed file names are gone.Merge order
Merge this after spicetify/classmaps#16.
rust-release.ymlcompares the SHA-256 of thisexpose.jsonwith the publishedindex.json. The new digest is9d6ceb35…, and it matches only once #16 is onmain.Verification
cargo test -p spicetify expose: 14 passed.test_classmap_capture.pypasses.bash -n scripts/classmap_e2e.shis clean.