test(manager): cover the self-update controls in both update panels - #43
Merged
Merged
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The automatic-update controls went missing from the Linux managed-Spotify panel once (fixed in #40) because the Manager has two update panels and nothing checked both. These tests render the real
ManagerPagein each mode and assert the controls are there.modules/manager/updatePanels.test.mts:SpicetifySelfUpdateon its own, andManagerPagein the regular panel and the managed Linux panel (manifestmanagedSpotify: "stable", asserting the "Linux stable" badge so the test knows which panel rendered). With a daemon reportingautoUpdateand a newer version than the manifest'scliVersion, the "Install Spicetify updates automatically" toggle and the "Spicetify X is installed. Apply to use it in Spotify." prompt appear inside the Updates section; with a daemon that predates the setting, the toggle is absent.react-test-renderer18.3.1 (matching React 18.3.1) as a devDependency. The stdlib import is stubbed withregisterHooks, as the lyrics-plus tests do.Testing
{children}frommanagedSpotify.tsxfails both Linux-panel tests; removing the regular branch's{selfUpdate}frompage.tsxfails both regular tests.release.ts status --soft: ok).