Skip to content

test(manager): cover the self-update controls in both update panels - #43

Merged
afonsojramos merged 2 commits into
mainfrom
test/manager-update-panels
Oct 1, 2026
Merged

afonsojramos merged 2 commits into
mainfrom
test/manager-update-panels

Conversation

@afonsojramos

Copy link
Copy Markdown
Member

Summary

The automatic-update controls went missing from the Linux managed-Spotify panel once (fixed in #40) because the Manager has two update panels and nothing checked both. These tests render the real ManagerPage in each mode and assert the controls are there.

  • modules/manager/updatePanels.test.mts: SpicetifySelfUpdate on its own, and ManagerPage in the regular panel and the managed Linux panel (manifest managedSpotify: "stable", asserting the "Linux stable" badge so the test knows which panel rendered). With a daemon reporting autoUpdate and a newer version than the manifest's cliVersion, the "Install Spicetify updates automatically" toggle and the "Spicetify X is installed. Apply to use it in Spotify." prompt appear inside the Updates section; with a daemon that predates the setting, the toggle is absent.
  • Adds react-test-renderer 18.3.1 (matching React 18.3.1) as a devDependency. The stdlib import is stubbed with registerHooks, as the lyrics-plus tests do.

Testing

  • 6 new tests pass with no React warnings. Removing {children} from managedSpotify.tsx fails both Linux-panel tests; removing the regular branch's {selfUpdate} from page.tsx fails both regular tests.
  • Manager tests: 44 pass. Test-only change, so no version bump (release.ts status --soft: ok).

@coderabbitai

coderabbitai Bot commented Oct 1, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 59 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: c712acd9-8b1d-4dd2-a2af-66ff7eea31ea

📥 Commits

Reviewing files that changed from the base of the PR and between 83062f9 and 6b741ff.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • modules/manager/updatePanels.test.mts
  • package.json
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@afonsojramos
afonsojramos merged commit a543b47 into main Oct 1, 2026
6 checks passed
@afonsojramos
afonsojramos deleted the test/manager-update-panels branch October 1, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant