Repository navigation
feat(lyrics-plus): Port Pinyin Romanization feature - #54
afonsojramos merged 2 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (11)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe lyrics module adds an optional pinyin conversion setting for Chinese lyrics. It converts lyrics per track and mode, then displays distinct romanized text beneath lyrics in synced, expanded synced, and unsynced views. ChangesChinese Lyrics Romanization
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant LyricsContainer
participant Translator
participant PinyinProScript
participant LyricsPage
LyricsContainer->>Translator: convert lyric text to pinyin
Translator->>PinyinProScript: load pinyin-pro script
PinyinProScript-->>Translator: provide pinyin converter
Translator-->>LyricsContainer: return romanized lines
LyricsContainer->>LyricsPage: pass matching romanization
Suggested reviewers: Merge Risk: ⚪ Minimal · up to No confirmed issue blocks merging. Same-track lyric replacement behavior remains unverified. Pre-merge checks |
|
I've been trying V3 beta and found out
lyrics-plusmodule is missing a feature that v2 has. So, this PR ports the pinyin romanization feature from the v2 custom appslyrics-plusto new v3lyrics-plusmodule. I also bumped version number from0.3.0to0.4.0. Thank you!Summary by CodeRabbit