Repository navigation
boot: an overlay is mounted once its NBD device has a size - #28
Merged
Merged
Conversation
On the kvm runner, the report's second boot mounted /dev/nbd0 while it still
had zero bytes - qemu-nbd returns before the kernel learns the device's size,
and the capacity change was logged 7 ms after the failed mount ("can't read
superblock"). The wait for a filesystem asked blkid, which answers from its
cache and said ext4 about the empty device. It now waits for a non-zero size
and probes with blkid -p.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On
kvm-runner, every report after the first boot failed with:A diagnostic run on the runner showed why:
qemu-nbd --connectreturns before the kernel knows the device's size. The wait before the mount askedblkid, which answers from its cache: it reportedTYPE="ext4"whileblockdev --getsize64returned 0. On a faster host the reconnect usually wins the race, which is why it never showed up locally.Change:
editOverlaynow waits for a non-zero size and probes withblkid -p, which bypasses the cache.Check: with this branch,
report.ymlonkvm-runneragainst v20260928.02 went green (run):hotplug=onrows are refused because that release's QEMU predates qemu: virtio-scsi and scsi-hd, and every build step fetches its own source #24 ('virtio-scsi-pci' is not a valid device model name), as expected.task lintpasses.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.