Repository navigation
AIP-5401/5403: integrate SLIM caller route with LAS - #249
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b09e5f1dab
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| var runtimeFeature *aiv1.FeatureSpec | ||
| for i := range platform.Spec.Features { | ||
| feature := &platform.Spec.Features[i] | ||
| if feature.Name != "agentruntime" { |
There was a problem hiding this comment.
Requeue cross-namespace SLIM services on platform changes
When a SLIM AIService references an AIPlatform in another namespace, this route is derived directly from the platform's AgentRuntime provider and assistant ID, but later platform updates will not refresh it: findAIServicesForPlatform in internal/controller/aiservice_controller.go only lists AIServices in the platform's namespace. Cross-namespace references are otherwise accepted and resolved here, so changing the provider can leave AGENT_SERVER_URL pointing to a deleted Service, while changing assistantId leaves LAS_GRAPH_ID stale until an unrelated reconciliation occurs. The platform watch must search all namespaces for matching references or cross-namespace references must be rejected.
Useful? React with 👍 / 👎.
| "SPLUNK_ISSUERS": splunkIssuersVal, | ||
| "ENABLE_AUTHZ": "false", | ||
| "ENABLE_AUTHN": "true", | ||
| "ENABLE_AUTHZ": "true", |
There was a problem hiding this comment.
Require a trusted issuer before forcing authentication
For any valid AIPlatform with Splunk integration disabled and no trustedIssuers, buildSplunkIssuersVal returns an empty string, yet these defaults unconditionally enable authentication and authorization. The admission webhook explicitly accepts an empty Splunk configuration, so this produces a healthy-looking SLIM deployment for which no bearer token can satisfy the empty issuer allowlist and every caller is denied. Either reject SLIM configurations without an issuer or provide another configured identity path rather than silently deploying an unusable endpoint.
Useful? React with 👍 / 👎.
AIP-5401 / AIP-5403 updated-image cluster retest — 2026-10-16Retested the supplied
The candidate, temporary pull Secret, synthetic LAS objects, port forwards, private tunnel, and exact temporary SSH rule were removed. Primary LAS/SLIM AIServices remained Ready with unchanged UIDs and Deployments 1/1. The dummy-graph mismatch is not an acceptance failure for either story. AIP-5401's compatible final-result check and the other qualification gaps above remain open; no story status or acceptance decision is changed by this comment. Merge and Jira closure update — 2026-10-16: PR #249 merged into |
37d2634 to
d2ef5a0
Compare
Summary
Implements the AIP-5401 SLIM-to-LAS route configuration and AIP-5403 caller access setup together, with focused unit coverage, an isolated cluster candidate manifest, sanitized probes, and the full acceptance record in the cluster validation document.
The product developer clarified that incremental LAS events are not required for this agent image; the final response is required. The strict
PLATFORM_URLrequirement will be modified, and the assistantID/threadID issue is under investigation.Acceptance record
success=false/http_error_code=500envelope.PLATFORM_URLstartup requirement; test candidate needed an unreachable loopback placeholder. The developer says this requirement will change.Verification
go test ./pkg/ai/features/slim -count=1passed.git diff --checkpassed.Cluster validation must be repeated after SLIM fixes assistant/thread UUID handling and the CPU-only
PLATFORM_URLrequirement.