Repository navigation
[AIP-5398/5400/5407] Add LAS lifecycle, readiness, and deployment coverage - #250
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 435b5965c2
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Limit this change set to the AIP-5398 LAS lifecycle tests and existing AIP-5400 readiness regressions. Remove the unrelated AIP-5407 installer and deployment changes from the open review.
|
Scope correction after review: the branch now contains only the AIP-5398 LAS lifecycle tests and AIP-5400 readiness/status regressions. The unrelated AIP-5407 installer/deployment changes have been removed. The PR title/body currently still reflect the old scope; I don’t have an edit-PR connector here, so please treat this note and the current changed-files list as authoritative. Tests remain intentionally unrun per the plan to test later. |
Restore the LAS deployment helper, installer credential handling, network policy allowlist reconciliation, related unit coverage, CI wiring, and installation guidance alongside the AIP-5398 and AIP-5400 regression tests.
Summary
Adds LAS lifecycle and readiness regression coverage for AIP-5398 and AIP-5400, plus installer-managed LAS secrets and egress controls for AIP-5407.
AIP-5398 — LAS lifecycle tests
AIP-5400 — health and status regressions
AIP-5407 — deployment configuration and egress
Validation
gofmt.git diff --checkpassed.Scope note
AIP-5402 caller-route tests are not included. They depend on a working AIP-5401 SLIM-to-LAS route and its agreed request/response contract.