CSPL-4610: Add CI check for stale generated files and mark them in .gitattributes#1767
Open
kubabuczak wants to merge 2 commits intodevelopfrom
Open
CSPL-4610: Add CI check for stale generated files and mark them in .gitattributes#1767kubabuczak wants to merge 2 commits intodevelopfrom
kubabuczak wants to merge 2 commits intodevelopfrom
Conversation
…check for uncommitted changes - Introduced .gitattributes to mark generated files for better handling in version control. - Enhanced the build-test-push workflow by adding a new job to check for uncommitted changes after code generation, ensuring generated files are up to date before proceeding with the build.
kubabuczak
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a CI gate to catch stale generated files (CRDs, RBAC, DeepCopy) and marks all generated files with
linguist-generatedso GitHub collapses them by default in PR diffs.Key Changes
.github/workflows/build-test-push-workflow.ymlcheck-generatedjob that runsmake manifests generateand fails ifgit diffdetects uncommitted changesbuild-operator-imagenow depends oncheck-generatedin addition tocheck-formatingandunit-tests.gitattributes(new file)api/**/zz_generated.deepcopy.go,config/crd/bases/*.yaml,config/rbac/role.yaml,config/rbac/role_binding.yaml,config/webhook/manifests.yaml,bundle/manifests/*.yaml,bundle/metadata/annotations.yaml, andconfig/manifests/bases/splunk-operator.clusterserviceversion.yamlaslinguist-generated=trueTesting and Verification
api/v4/without runningmake manifests generate) — the newcheck-generatedjob should faillinguist-generatedbehavior is verified by GitHub automatically on any PR that touches these files — they will appear collapsed in the diff viewRelated Issues
PR Checklist