Move postgres controller code to package, cleanup crds, fix minor issues#1791
Conversation
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
eca7bec to
eff8782
Compare
eff8782 to
05055ac
Compare
DmytroPI-dev
left a comment
There was a problem hiding this comment.
We have pkg/postgresql/database/core/types.go and pkg/postgresql/cluster/core/types.go, both in core package, can we have some conflicts here?
We might, in this case we can have separate "shared" directory with reusable types later on. Currently most of the things are not shared |
| CNPG *enterprisev4.CNPGConfig | ||
| } | ||
| const ( | ||
| ClusterTotalWorker int = 2 |
There was a problem hiding this comment.
Nit: Is that a requirement for SOK? I wasn't testing the code against two parallel goroutines running at the same time. Does it work such that one worker starts on an event, but if it's still processing and another event comes in, it doesn't just sit in the queue, it can be picked up by another worker? I’d like to trigger that for future local tests, that's why I’m asking.
There was a problem hiding this comment.
They just asked us to provide this info explicit. Yes your assumption is correct how it works, with one exception: if changes is related to the same CR it still will be queued to provide proper serialisation
Description
What does this PR have in it?
Key Changes
Highlight the updates in specific files
Testing and Verification
How did you test these changes? What automated tests are added?
Related Issues
Jira tickets, GitHub issues, Support tickets...
PR Checklist