Skip to content

Fix JSON results streaming without readlines#742

Open
J0JIN wants to merge 1 commit into
splunk:developfrom
J0JIN:fix-json-results-streaming
Open

Fix JSON results streaming without readlines#742
J0JIN wants to merge 1 commit into
splunk:developfrom
J0JIN:fix-json-results-streaming

Conversation

@J0JIN
Copy link
Copy Markdown

@J0JIN J0JIN commented Apr 23, 2026

Summary

  • Iterate over JSON result streams directly instead of calling readlines()
  • Add a unit test to ensure JSONResultsReader does not require readlines()

Testing

  • uv --no-config run python -m pytest --no-header --ff -ra -vv ./tests/unit/test_results.py
  • uv --no-config run basedpyright tests/unit/test_results.py splunklib/results.py

@Ickerday
Copy link
Copy Markdown
Collaborator

Ickerday commented May 14, 2026

Hi, this is obviously vibe-coded, so what's the motivation behind this? Have you considered what impact this would have on existing SDK users? Additionally - what value do you see in this unit test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants