Repository navigation
Conversation
ValueRecorder.record now uses a type parameter for its argument and return value, preserving the recorded expression's static type without changing the recording logic. Regression coverage exercises properties and public fields across then, expect, and explicit assertions in when. Additional cases check that failing conditions still record the receiver, operands, and result for both string and null values. Fixes spockframework#2343
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to No actionable merge-blocking issue is established. Run the new regression tests as part of normal validation. Pre-merge checks |
 |
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly and concisely describes the main change: preserving the type of values recorded by ValueRecorder.record. |
| Description check | |
The description accurately explains the ValueRecorder.record type change, the related @TypeChecked regression, test coverage, and build result. |
| Linked Issues check | |
The change addresses issue #2343. ValueRecorder.record now returns the generic type T of its input, so static type checking can preserve the receiver type after recording. The regression tests cov… |
| Out of Scope Changes check | |
The pull request changes only ValueRecorder.record and adds focused regression tests in StaticTypeChecking for issue #2343. The tests directly validate the required type preservation and condition… |
| Docstring Coverage | |
Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 … |
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
A rabbit reads the types in line
And finds the field where values shine
The recorder gives the same type back
Conditions stay on the proper track
I hop away with tests in tow
Comment @coderabbitai help to get the list of available commands.
 |
|
Thanks, but there is waaaay more necessary to properly support STC, and we are already working on it in #2397, so I'm closing this as duplicate. |
2 participants
ValueRecorder.record now uses a type parameter for its argument and return value, preserving the recorded expression's static type without changing the recording logic. Regression coverage exercises properties and public fields across then, expect, and explicit assertions in when. Under @TypeChecked, accessing a spec field or property through explicit this in a condition can fail compilation because the receiver is treated as Object. This affects then and expect conditions, as well as explicit assertions in when blocks.
The testClasses build completed successfully; the transcript shows compilation, not test execution.
Fixes #2343
AI was used for assistance.