Document @RefreshScope + @ControllerAdvice double-invocation issue (GH-1452)#3248
Open
won-seoop wants to merge 1 commit into
Open
Document @RefreshScope + @ControllerAdvice double-invocation issue (GH-1452)#3248won-seoop wants to merge 1 commit into
won-seoop wants to merge 1 commit into
Conversation
…pring-cloudGH-1452) Add a 'Refresh Scope Known Limitations' section to the client docs documenting that applying @RefreshScope directly to @ControllerAdvice beans causes @ModelAttribute methods to be invoked twice per request due to CGLIB proxy double-registration. Include the recommended workaround: extract the refreshable config into a separate @ConfigurationProperties/@RefreshScope bean and inject it into the @ControllerAdvice without @RefreshScope on the advice itself. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes GH-1452
Applying
@RefreshScopedirectly to a@ControllerAdvicebean causes Spring MVC to discover both the CGLIB proxy (from the refresh scope) and the underlying target class. As a result,@ModelAttributemethods are invoked twice per request.The maintainers already recommended the workaround in the issue thread: extract refreshable values to a separate
@ConfigurationPropertiesbean with@RefreshScopeand inject it into the advice. However, this was never documented, leaving users to discover it on their own.Changes
Added a new
[[refresh-scope-known-limitations]]section toclient.adoc(placed before the AOT section at the end of the page):@RefreshScopeand which doesn'tTest plan
🤖 Generated with Claude Code